Thread: while runs foreverly

Code:

#include <iostream>
#include <iomanip>

using namespace std;

string oddOrEven(int);

int main()
{

int x;

while(1 == 1)
{
    cout<<"Enter a number: ";
    cin>>x;
    if(x==0)
    {
        cout<<"You've chosen to quit. BYE."<<endl;
        cin.get();
        cin.get();
        break;
    }
    cout<<"Number is "<<oddOrEven(x)<<endl<<endl;
    cin.get();
}

}

string oddOrEven(int n)
{
    return ((n % 2) == 0) ? "even" : "odd";
}

The code works okay, but if the user input a character instead of a number when asked, the program runs the while structure foreverly, how can i fix this?
btw, any tips on making the code cleaner are welcome

Of course it will run forever. You test for "1 == 1" which is always true. 1 always will equal 1.

This loops until the user inputs zero:

Code:

#include <iostream>
#include <stdbool.h>
using namespace std;

bool isodd(int x){
    return ( x % 2 ) != 0;
}

int main(){
    
    int x;
    
    cin >> x;

    while(x){
        if(isodd(x))
            cout << "Odd" << endl;
        else
            cout << "Even" << endl;
        cin >> x;
    }

    return 0;

}

Of course it will run forever. You test for "1 == 1" which is always true. 1 always will equal 1.

no thats not the problem. You see, it's meant to run that way until the user inputs 0, then the program will close. If you type a number it will display wheter the number is odd or even. So far so good. But if the user type a character instead of a number, the program will run a very annoying loop.