Please solve this issue, you can run this program.. its complete
Code:#include<iostream> #include<cstdlib> #include<string> using namespace std; struct node { string name; int i; }; int main(int argc, char *argv[]) { struct node *first; first = (struct node *) malloc(sizeof(struct node)); first->name ="Hi there"; cout << first->i; }
Why use malloc? Use new as you wont be calling constructors for std::string without it.
Dont forget to call delete also
Don't use malloc() to create "first" in main(). Use operator new instead.
Also initialise first->i to a valid value before trying to print it.
Can you tell me the exact code to use the new for this?
and make me clear why this is throwing segmentation fault(core dump)?
I don't this this is happening for malloc?
Look it up in the faq - Cprogramming.com FAQ > Dynamic Memory Allocation: new and delete (C++)
The problem is likely to be that malloc is not calling the constructor on the string object in your struct, so the use of the object is risky to say the least
Again, 'malloc' just allocates a chunk of memory, whereas 'new' allocates and then invokes the constructor on the object (and in turn, it's sub-objects). The 'string' object in your code isn't properly initialized by it's constructor, so its state is indeterminate.Originally Posted by kapil1089thekin
Code:#include <cmath> #include <complex> bool euler_flip(bool value) { return std::pow ( std::complex<float>(std::exp(1.0)), std::complex<float>(0, 1) * std::complex<float>(std::atan(1.0) *(1 << (value + 2))) ).real() < 0; }
Is it good practice to use in c++? or there is a better way let me know, actually I am good in c but may be intermediate in c++, most of the time I cant find the diffrence between them and so I use c codes, how to know more using c++ features and diffrentiate between the c++ and C coding, I would also appreciate the notion of good coding practice in c++
Well I looked at your code in the debugger, and the string object was garbage just after calling malloc.
If anything you're allocating space for has a C++ class in it, then you MUST use new to allocate the space for it, so that the class constructor can be called.
If you don't, then the class instance contains garbage and you most likely crash as a result.
If you dance barefoot on the broken glass of undefined behaviour, you've got to expect the occasional cut.
If at first you don't succeed, try writing your phone number on the exam paper.
Is it good to use structure in C++?
and how to use new here in my code to make it work?
just make the necessary changes and post the code, thanks in advance.
If it makes more sense to use a C-style struct in a given situation, go right ahead.
See here.
Code:#include <cmath> #include <complex> bool euler_flip(bool value) { return std::pow ( std::complex<float>(std::exp(1.0)), std::complex<float>(0, 1) * std::complex<float>(std::atan(1.0) *(1 << (value + 2))) ).real() < 0; }
Kapil,
The other posters are suggesting using 'new' rather than just getting a piece of memory from the heap with 'malloc.' The rationale is that the new operator triggers the constructor of composite (or aggregated) datatypes, like your struct in this example. To provide a precise answer, this is a known solution:
The output I received when I used Dev-C++ in Windows is "0," then I modified it to print the string which had been assigned to name. This was also successful. I was trying to recall if there was a way to call the string member's constructor manually once it had been allocated by malloc...but I don't recall one at the moment.Code:#include<iostream> #include<cstdlib> #include<string> using namespace std; struct node { string name; int i; }; int main(int argc, char *argv[]) { struct node *first; first = new struct node; first->name ="Hi there"; cout << first->i; }
Best Regards,
New Ink -- Henry
As Salem noted, there should be a corresponding delete. One can also write node instead of struct node despite the lack of a typedef since this is C++.
Under different circumstances, placement new would be an option to construct a node object at the allocated memory, but I would not suggest it here. In fact, I would not even suggest dynamic memory allocation here to begin with, but presumably kapil1089thekin was just experimenting.
Look up a C++ Reference and learn How To Ask Questions The Smart Way
It's called "placement new", and it should be used only in very special cases.
Code:#include <string> #include <iostream> int main( void ) { using namespace std; string* str = static_cast< string* >( malloc( sizeof( string ) ) ); /* Manually invoke the constructor. */ new ( str ) string( "Hello World!" ); cout << *str << endl; /* We can't use 'delete' because it may not be compatible with the result of our 'malloc' call, so we have to invoke the destructor and 'free' the memory manually. */ str->~string( ); free( str ); }
Code:#include <cmath> #include <complex> bool euler_flip(bool value) { return std::pow ( std::complex<float>(std::exp(1.0)), std::complex<float>(0, 1) * std::complex<float>(std::atan(1.0) *(1 << (value + 2))) ).real() < 0; }
Thank you all posters, I am immensely satisfied with your answer, but knowing new things is the best pleasure I can have, so I am asking again a qn which may sound vacuous to all of you,
1.Do I need to delete each node in a linked list if I get each node'e memory allocation by calling new?
2. In that case it will add O(n) time complexity more? right?
3.Is there any better solution for freeing the memory?
Yes, you should.
Yes.
No. There is a minimum amount of work to be done for anything, and in the case of destroying a linked list of n nodes, this is it.
Look up a C++ Reference and learn How To Ask Questions The Smart Way
