Thread: Need help with counting vowels prog

Here's one way to do it:

Code:

#include <iostream>  
#include<fstream>  

using namespace std;      
int main( )  
{  
ifstream inFile;   

char c;  
int numOfVowels = 0;   
int numOfAs = 0;
int numOfEs = 0;
int numOfIs = 0;
int numOfOs = 0;
int numOfUs = 0;

inFile.open("j://cppproj 3.txt");  

while(!inFile.eof())  

{  
inFile.get(c);  

switch (c) {
    case 'A':
        numOfAs++;
        break;
    case 'a':
        numOfAs++;
        break;
    case 'E':
        numOfEs++;
        break;
    case 'e':
        numOfEs++;
        break;
    case 'I':
        numOfIs++;
        break;
    case 'i':
        numOfIs++;
        break;
    case 'O':
        numOfOs++;
        break;
    case 'o':
        numOfOs++;
        break;
    case 'U':
        numOfUs++;
        break;
    case 'u':
        numOfUs++;
        break;
}
	
numOfVowels++;  
}  

inFile.close();

cout << "The total number of vowels is " << numOfVowels << ".\n";  
cout<< "The total number of A's is: " << numOfAs <<endl;
cout<< "The total number of E's is: " << numOfEs <<endl;
cout<< "The total number of I's is: " << numOfIs <<endl;
cout<< "The total number of O's is: " << numOfOs <<endl;
cout<< "The total number of U's is: " << numOfUs <<endl;
return 0;  

}

Code:

char toUpper(char *c)
{
    return((*c >= 0x61 && *c <= 0x7A) ? *c &= 0xDF : *c);
}

You guys seems to be missing this...

You shouldnt give him a complete example when he was so close to what he wanted... He just had to think a little longer... programmers need to think by themselfs.

Originally Posted by Dante Wingates

You guys seems to be missing this...

Just as you've missed the existence of a standard function for conversion to upper case, and the fact that your function assumes a specific (type of) character set.

Of course, the examples here presume the english language as well.

The actual definition of a vowel is a bit deeper than "in the set aeiou".

The phonetic definition of a vowel is a sound in spoken language pronounced with an open vocal tract so that there is no build-up of air pressure at any point above the glottis. This contrasts with consonants where there is a constriction or closure at some point along the vocal tract.

The phonological definition of a vowel is "sound that forms a peak of a syllable" (the 'a' in "cat" is the peak).

Technically, there is sometimes conflict between these definitions. For example, 'y' and 'w' (as pronounced in the English words "yes" and "wet") are produced without much constriction of the vocal tract so, phonetically they can be considered to be vowels but phonologically they are not pronounced at the peak.

If you want a real challenge, try to write a program that counts vowels - by one of these definitions - that works for any spoken or written language

Originally Posted by grumpy

Just as you've missed the existence of a standard function for conversion to upper case, and the fact that your function assumes a specific (type of) character set.

No, Im completly aware of that. The fact that I wrote a simple function was simply because I felt like it.

Im not missing the existence of standard functions, but I often encourage people to write their own functions, that is a matter of opinion. But you've missed one thing: It was not written to convert any character set nor only vowels to upper case. This simple function was written with the ascii character set in mind, so it works with it. Complaining about that is the same as saying that a ps3 should run xbox 360 games simply because both consoles were made to run games.

Of course, the examples here presume the english language as well.

The actual definition of a vowel is a bit deeper than "in the set aeiou".

The phonetic definition of a vowel is a sound in spoken language pronounced with an open vocal tract so that there is no build-up of air pressure at any point above the glottis. This contrasts with consonants where there is a constriction or closure at some point along the vocal tract.

The phonological definition of a vowel is "sound that forms a peak of a syllable" (the 'a' in "cat" is the peak).

Technically, there is sometimes conflict between these definitions. For example, 'y' and 'w' (as pronounced in the English words "yes" and "wet") are produced without much constriction of the vocal tract so, phonetically they can be considered to be vowels but phonologically they are not pronounced at the peak.

If you want a real challenge, try to write a program that counts vowels - by one of these definitions - that works for any spoken or written language

... So? Again, the function was written to convert any ascii character set lower case letter to its upper case representation, not only its vowels. My first language is portuguese(português) for Im brasilian. You can safely say that Im aware of that better than many english speakers, but it should come as no surprise that Im not worried with that now.

Now try this and tell me if it is not doing what it is supposed to

Code:

#include <iostream>

char toUpper(char c)
{
    return((c >= 0x61 && c <= 0x7A) ? c &= 0xDF : c);
}

int main(int argc, char **argv)
{
    for(char c = 0x20; c <= 0x7E; c++)
        std::cout << toUpper(c) << (char)0x20;
    std::cin.get();
    return(0);
}

let me know if it is printing any lower case letter.

Originally Posted by MWAAAHAAA

So you recommend people to waste their time reinventing the wheel, instead of using a solid, proven, readily available solution.

Plus reinventing the wheel with the poor use of magic numbers and assumptions (however warranted) that remain undocumented until challenged...

Code:

inFile.open("j://cppproj 3.txt");  

while(!inFile.eof())

Don't use eof to control a loop.