Thread: problem with iteratiors

Hi there

I'm having trouble with an iterator, I have used them very often so I'm not sure why i'm getting the error

heres my code

Code:

    void food::draw(Canvas &canvas)
    {
            for (Position foodpositions_[5]::iterator i = foodpositions_[0]; i != foodpositions_[5]; ++i)
                {
                    canvas.blit(foodImage_,0,0,20,20, i->foodpositions_[].x_, i->foodpositions_[].y_);
                }
    }

the compiler says;

Line 81 error: expected initializer before ‘::’ token

line 81 error: ‘i’ was not declared in this scope

line 83 error: expected primary-expression before ‘]’ token

line 83 error: expected primary-expression before ‘]’ token

the idea behind this code is that it will loop through an array for 5 elements and then blit the contents of each element to the screen.

Thanks in advance for any help given

ES

What is foodpositions_[5]???
Your "i" is declared anywhere?
what is foodpositions_[0]???

foodpositions_[ ]is an array of 5 structures that hold two ints.

its declared elsewhere in the code, heres a looky

Code:

//decleration of position

struct Position
{
    int x_;
    int y_;
    Position(int x,int y) : x_(x), y_(y){}
};

Code:

//declaration within the food class
Position foodpositions_[5];

I believe i is declared here;

Code:

 for (Position foodpositions_[ ]::iterator i = foodpositions_[0]; i != foodpositions_[5]; ++i)

but like I said, I'm unfamiliar with using iterators, does it need to be declared somewhere else?

That isn't an iterator. It's wrong. Maybe look up a C reference on how to implement one.

Ok, I've done away with the whole iterator thing and now I haev this

Code:

    void food::draw(Canvas &canvas)
    {
            for (prog = foodpositions_[prog]; prog != foodpositions_[5]; ++prog)
                {
                    canvas.blit(foodImage_,0,0,20,20, prog->foodpositions_[prog].x_, prog->foodpositions_[prog].y_);
                }
    }

I'm only getting one error now that says prog was not declared in this scope on the line the for loop declared. is there something wrong with my syntax?

Did you declare prog at any point? Using int prog or the like? Not that your for loop will work anyway, as you can't keep both the index and the value from the array in the same variable. Perhaps you just want the completely ordinary and uninteresting

Code:

for (int prog = 0; prog < 5; ++prog)

instead.

You have come up with this, because you don't know anything about iterators.
Secondly, your "prog" must be defined somewhere.

I would say, please refer to your books to fix your problem, and have a better understanding.

Ok, I've done some reading, but now I'm not sure if iterators can even be used in an array.

All the examples I've read only use iterators with lists and vectors from the STL.

can they be used with an array? if so, I just need to know how to get it started.

I know you define an iterator for a vector like this;

Code:

vector <int>:: iterator iter

and doing for a list is similar, just using list linstead of vector.

so can I define an iterator for an array like this

Code:

foodpositions_<Position>:: iterator iter

Why are you not reading book?
Your foodpositions is an array of position. It is not a container.
Read something on STL, you will get some idea about containers, and iterators

Originally Posted by elsparko

Ok, I've done some reading, but now I'm not sure if iterators can even be used in an array.

All the examples I've read only use iterators with lists and vectors from the STL.

can they be used with an array? if so, I just need to know how to get it started.

I know you define an iterator for a vector like this;

Code:

vector <int>:: iterator iter

and doing for a list is similar, just using list linstead of vector.

so can I define an iterator for an array like this

Code:

foodpositions_<Position>:: iterator iter

There are no iterator types for base types. Or to put it another way, the iterator for an array is "pointer to T", which you can use ++ on.