Thread: Problems with copying strings

Ok, so I am working at a program that operates with sets. Each set has a name and an array for its elements. The user inputs for example "Alpha: 1 2 3 4 5", where Alpha is the name. I have to parse the string so that I get what's before the : symbol. It works perfectly with name declared as static (such as char name[10]), but when I am allocating memory for exactly as many characters as there are before the : , then I get either errors, either "Press any key to continue"... I used strncpy and also a function implemented by myself, but to no use.

Does anyone have another idea for implementing this? Thank you.

Code:

 class CMultime
{
	int* m_Elemente;
	char* m_Nume;
public:
	void preiaNume(char* sursa)
	{
		int caractere = 0;
		int lungime = strlen(sursa);
		for(int i = 0; i < lungime; i++)
		{
			if(sursa[i] != ':')
			{
				caractere++;
			}
			else
			{
				break;
			}
		}
		if(caractere)
		{
			m_Nume = new char[ caractere ];
			for(int i = 0; i < caractere; i++)
				*(m_Nume + i) = *(sursa + i);
		}
		else
		{
			cout << "Nu ai respectat formatul sau nu ai introdus numele multimii." << endl;
		}
	}

This would be it. After using a function to display m_Nume, I get the string before : and some ASCII weird stuff.

Originally Posted by MK27

You need to null terminate this string.

Thank you! This is the modified version.

Code:

for(i = 0; i < caractere; i++)
				*(m_Nume + i) = *(sursa + i);
			*(m_Nume + i) = NULL;

Now, the main has

Code:

 void main()
{
	CMultime prima;
	char sir[10];
	cin.getline(sir, 10);
	prima.preiaNume(sir);
	prima.afis();
}

. It compiles great, it even gets me the string, but I hear a sound and the program does not stop. But thank you very much.. I forgot about that NULL ending.

Sorry. From now on I will translate it. I found the problem myself. It is because when I say *(m_Nume + i) = NULL, it puts the NULL into the next element.. which does not belong to the string because of the dimension. Therefore, I make new char [caractere + 1] instead. Thank you for all your replies.