What's wrong with this code?

**Code Thug** · 03-02-2010

Just something I was trying to do off of the top of my head.

Code:

#include <stdafx.h>
#include <cmath>
#include <cstdlib>
#include <iostream>

using namespace std;

class vegetable{


public:

	int broccoli;
	int carrot;
	int bean;
	static int corn;
	int cauliflower;

}


int main()
{
	char cornanswer;
	char Y = "Y";



	cout << " Is  " << vegetable::corn << "a vegetable?";
	cout << "Say Y for yes and N for no";
	cin >> cornanswer;

	if (cornanswer == Y)
	{
		cout << "YES!! You are very smart, it is a vegetable!";
	}

	else
	{
		cout << "Wow, you are very stupid! That answer is wrong!";
	}

	return 0;

}

I've looked it over dozens of times, and I can't seem to find what I did wrong. I think it has something to do with calling on the corn variable inside the class though.

Build Errors.

Code:

1>Mess.cpp(24): error C2628: 'vegetable' followed by 'int' is illegal (did you forget a ';'?)
1>Mess.cpp(25): error C3874: return type of 'main' should be 'int' instead of 'vegetable'
1>Mess.cpp(27): error C2440: 'initializing' : cannot convert from 'const char [2]' to 'char'
1>          There is no context in which this conversion is possible
1>Mess.cpp(45): error C2440: 'return' : cannot convert from 'int' to 'vegetable'
1>          No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called

**prog-bman** · 03-02-2010

Need Semi colon at the end of vegetable

**rags_to_riches** · 03-02-2010

Code:

Mess.cpp(27): error C2440: 'initializing' : cannot convert from 'const char [2]' to 'char'

"Y" is a constant char array consisting of the letter Y and the null terminator character (hence the const char[2] in the error message); a single character should be enclosed in single quotes, not double quotes.

**bernt** · 03-02-2010

Also you need a semicolon after the declaration of vegetable:

Code:

...
        int bean;
	static int corn;
	int cauliflower;

}; //<- here

The compiler thinks that main is an instance of class vegetable since the semicolon isn't there, but this is obviously not the case.
Also you need single quotes around the 'Y' here:

Code:

if (cornanswer == Y)

On another note,

Code:

cout << " Is  " << vegetable::corn << "a vegetable?";

isn't going to print "Is corn a vegetable?", if that's what you were going for - vegetable::corn is an int, so it will be something like "Is 0 a vegetable?".

Which makes me think of the comical situation that could ensue:

Code:

>./mess
Is 0 a vegetable?
Say Y for yes and N for no
>N
Wow, you are very stupid! That answer is wrong!
>wtf
wtf: command not found
>sudo rm ./mess

**Code Thug** · 03-02-2010

Originally Posted by bernt

Also you need a semicolon after the declaration of vegetable:

Code:

...
        int bean;
	static int corn;
	int cauliflower;

}; //<- here

The compiler thinks that main is an instance of class vegetable since the semicolon isn't there, but this is obviously not the case.
Also you need single quotes around the 'Y' here:

Code:

if (cornanswer == Y)

On another note,

Code:

cout << " Is  " << vegetable::corn << "a vegetable?";

isn't going to print "Is corn a vegetable?", if that's what you were going for - vegetable::corn is an int, so it will be something like "Is 0 a vegetable?".

Which makes me think of the comical situation that could ensue:

Code:

>./mess
Is 0 a vegetable?
Say Y for yes and N for no
>N
Wow, you are very stupid! That answer is wrong!
>wtf
wtf: command not found
>sudo rm ./mess

XD. Hahaha Thanks for pointing out my mistakes, all of you. And thank you for adding that extra note Bernt. If I do want it to say 'corn', would it be the following in the vegetable class? :

Code:

const char corn = 'corn';

**bernt** · 03-02-2010

Code:

const char corn = 'corn';

C Tutorial: Lesson 9 - Strings

**iMalc** · 03-03-2010

You definitely do not want to be using a truncated multicharacter constant there.

**Code Thug** · 03-03-2010

Originally Posted by bernt

C Tutorial: Lesson 9 - Strings

Ah, yes thank you. I couldn't remember the syntax for a string.

Also, you guys took most of the bugs out, but when I compile this

Code:

#include <stdafx.h>
#include <cmath>
#include <cstdlib>
#include <iostream>

using namespace std;

class vegetable

{


public:

	int broccoli;
	int carrot;
	int bean;
	static int corn;
	int cauliflower;

};


int main()
{
	char cornanswer;
	char Y = 'Y';



	cout << " Is  " << vegetable::corn << "a vegetable?";
	cout << "Say Y for yes and N for no";
	cin >> cornanswer;

	if (cornanswer == 'Y')
	{
		cout << "YES!! You are very smart, it is a vegetable!";
	}

	else
	{
		cout << "Wow, you are very stupid! That answer is wrong!";
	}

	return 0;

}

I get these Build Errors:

Code:

1>Mess.obj : error LNK2020: unresolved token (0A000332) "public: static int vegetable::corn" (?corn@vegetable@@2HA)
1>Mess.obj : error LNK2001: unresolved external symbol "public: static int vegetable::corn" (?corn@vegetable@@2HA)

Which I've never seen before.

**GReaper** · 03-03-2010

Υοθ αρε ηοπελεσσ. Ι ψαν'τ τακε τηισ ανυ μορε!!!!!

**Elysia** · 03-03-2010

Add...
int vegetable::corn;
...at global level.

Since static variables aren't part of the instances of a class, you only declare them in the class, and not define them. So you need to add a definition at global level.

And do try to speak english in an english-speaking forum!

**anon** · 03-03-2010

And do try to speak english in an english-speaking forum!

That is English, just typed with a Greek keyboard/Symbol font. A bit rude and unconstructive, though there might be some truth.

You probably don't need that vegetable class as you have it at all, and need something like:

Code:

    ...
    std::string plant = "corn";
    std::cout << "Is " << plant << " a vegetable?";
    ...

You probably have some misunderstanding about variable names. These are identifiers used by a coder. To store "words" use a string object.

If you want to pose multiple questions later, you'd probably need something like:

Code:

class Plant
{
     std::string m_name;
     bool m_vegetable;
public:
     Plant(const std::string& name, bool is_vegetable);
     std::string get_name() const;
     bool is_vegetable() const;
};

int main()
{
    Plant plants[] = { Plant("corn", true), Plant("carrot", true), ... };
    ...
    std::cout << "Is " << plants[random].get_name() << " a vegetable.";
    if (answer == 'y' && plants[random].is_vegetable() || answer == 'n' && !plants[random].is_vegetable()) {
        std::cout << "Correct";
    }
    ...

**Elysia** · 03-03-2010

Originally Posted by anon

That is English, just typed with a Greek keyboard/Symbol font. A bit rude and unconstructive, though there might be some truth.

But the point is... can I read it? I cannot. Hence, the criticism.
What is the point of a reply if others cannot read it?

**GReaper** · 03-03-2010

Well done anon!!

I wanted to test your deciphering abilities, although it was pretty simple...

Sorry if i caused frustration, i guess i shouldn't me using this topic for my silly games.

**Code Thug** · 03-03-2010

Lol, thanks for all of your help guys. Started learning WinAPI programming from XoaX. Unless there's an easier tutorial list out there, please let me know.

**bernt** · 03-03-2010

Originally Posted by Code Thug

Lol, thanks for all of your help guys. Started learning WinAPI programming from XoaX. Unless there's an easier tutorial list out there, please let me know.

This was my favorite

Thread: What's wrong with this code?

Thread Tools

Search Thread

Display

What's wrong with this code?

Similar Threads

What's wrong with my code?

what is wrong in this simple code

what is wrong with this code please

I cant find what is wrong with this code

very simple code, please check to see whats wrong