Thread: couple questions for very small random number program

Hey I am trying to make a smal random number game just for practice and have 2 questions. First I'm wondering if im generating the random number (between 1 and 100) the correct way. Second I am wondering how to loop this program (preferably with a for loop) so it will ask more than 1 time and then produce the answer, if the answer isnt correct then I obviously want it to ask then answer again. I am not sure you can use a for with the if-else? Anyways any help will be appreciated, thanks.

Code:

#include <iostream>
#include <ctime>
#include <cstdlib>
using namespace std;

int main ()
{
   int guess;
   double random;
   int i;






   cout << " I'm guessing of a number between 1 and 100 can you guess it?\n";
   cin >> guess;


   srand(time(NULL));
   random = rand() % (100 + 1);





   if (random > guess)
    cout << "Guess was too big\n";
   else if (random < guess)
     cout << "Guess was too small\n";
   else if (random == guess)
     cout << "You got it!\n";
     
     
     
     system ("pause");
     
     return 0;
     
     }

Code:

   
   if (random > guess)
    cout << "Guess was too big\n";
   else if (random < guess)
     cout << "Guess was too small\n";
   else if (random == guess)
     cout << "You got it!\n";

You need to put 'guess' first.
As in:

Code:

   if (guess > random)
    cout << "Guess was too big\n";
   else if (guess < random)
     cout << "Guess was too small\n";
   else if (guess == random)
     cout << "You got it!\n";

And your random number is going to be between 1 and 101, not 1 and 100.
A formula for random numbers is: rand() % (max - min) + min
So that would be: rand() % (100 - 1) + 1
which could be simplified to rand() % 99 + 1

You could use a while loop to make the program continue to ask for your guess.

Code:

#include <iostream>
#include <ctime>
#include <cstdlib>
using namespace std;

int main ()
{
int guess;
double random;
int i;
srand(time(0)); //Don't use NULL?

cout << " I'm guessing of a number between 1 and 100 can you guess it?\n";
random = rand() % 99 + 1;

while (true) //Loop infinitely (or until a 'break' command is called)
{
cin >> guess; //Ask for input


if (guess > random)
   cout << "Guess was too big\n";
else if (guess < random)
   cout << "Guess was too small\n";
else
{
   cout << "You got it!\n";
   break; //Break out of the while loop!
}
} //End bracket for while loop


system("PAUSE");

return 0;

}

Thanks guys got it figured out.

You've either failed at doing correct indentation, or at keeping your function to an appropriate length, or both.

Or I'm just too lazy to press the spacebar twenty times to indent the code while in the reply text box.

Incorrect!
The formula is rand() % (max - min + 1) + min

Whoops! Guess I screwed that one up.....