Thread: Help

Sure, at the top, use this instead

Code:

#include<iostream>
#include<conio>

Ok, please mark as SOLVED.

Seriously though, what kind of errors are you getting?

Void function is totally wrong ,, Can u help me with that??

Code:

if (name =='(' || '{' || '[')
     {
     a.push(name);
     }
     if (name ==')' || '}' || ']' )

This part is wrong though I see you had the right idea after it. You need a condition that evaluates to true or false (or 1 or 0) in between || or &&. '{' does not evaluate to true of false so change that to (name == '{') and what is name? It is an array of chars, you should be using name[i] there.

Code:

void function()

 {
	for (int j = 0; j <MAX; j++)
	{

		if (name[j] =='(' || '{' || '[')
		{
		 a.push(name[j]);
		}

			if (name[j] ==')' || '}' || ']' )
			{
			if (a.isEmpty() !==0)
			{
			a.pop();
			if ((name[j] == '}') || (name[j] == ']') || (name[j] == ')') )
			cout<<"valid"; }

			else if (a.isEmpty()==0)
			{
			cout<<"Invalid:";
			}
	  }             }

}

Now still its not working!!
Error: Functions containning for are not expanded inline!!

Originally Posted by Fatima Rizwan

Code:

void function()

 {
	for (int j = 0; j <MAX; j++)
	{

		if (name[j] =='(' || '{' || '[')
		{
		 a.push(name[j]);
		}

			if (name[j] ==')' || '}' || ']' )
			{
			if (a.isEmpty() !==0)
			{
			a.pop();
			if ((name[j] == '}') || (name[j] == ']') || (name[j] == ')') )
			cout<<"valid"; }

			else if (a.isEmpty()==0)
			{
			cout<<"Invalid:";
			}
	  }             }

}

Now still its not working!!
Error: Functions containning for are not expanded inline!!

Error

[code]
if (name[j] =='(' || '{' || '[')
[code]

should be

Code:

if (name[j] =='('  || name[j] == '{' || name[j] == '[')

Code:

if (a.isEmpty() !==0)

invalid

Originally Posted by Fatima Rizwan

Code:

if (a.isEmpty() !==0)

invalid

See in your code

[code]
void isEmpty(char top)
{
if (top == 0)
{
cout<<"Stack is EMPTY";
}
}
[code]

the signature and def of function it didn't return anything but

Code:

if (a.isEmpty() !==0)

here how can you compare with the function return value as it didn't meant to return any thing

Code:

#include<iostream.h>
#include<conio.h>

const int MAX=15;

class Stack
   {
   char array[MAX];
   char top;

   public:

   Stack()
   {
   top=0;
   }

   void push(char a)
   {
	if (top<MAX)
	{
	array[top]=a;
	top++;
	}
   }

 char pop()
 {
 top--;
 return array[top];
 }

 int isEmpty()
 {
 if ( top == 0)
 { cout<<"Empty stack"; }
 return 0;
 }

 };

 class BracketChecker
 {
 char name[MAX];
 Stack a;

 public:

 void input()
 {
 cin>>name;
 }

 char* getinput()
 {
 return name;
 }

 void function()
  {
	for (int j = 0; j <MAX; j++)
	{
		if (name[j] =='(' || name[j]== '{' || name[j]=='[')
		{
		 a.push(name[j]);
		}

			if (name[j] ==')' || name[j]=='}' || name[j]==']' )
			{
			if (!a.isEmpty())
			{
			a.pop();
			if ((name[j] == '}') || (name[j] == ']') || (name[j] == ')') )
			cout<<"valid"; }

			else if (a.isEmpty()==0)
			{
			cout<<"Invalid:";
			}
	  }             }

}
};

int main()
{
clrscr();
BracketChecker b;
b.input();
b.function();
getch();
return 0;
}

What ever sequence i give it says valid input,, I dun know how to pop and compare the brackets,, Can you help me with the highlighted part??

Originally Posted by Fatima Rizwan

What ever sequence i give it says valid input,, I dun know how to pop and compare the brackets,, Can you help me with the highlighted part??

Logic will be

there will be 3 different braces types

push and increment the brace type

and pop the brace type

if there is any value greater than 0 on the stack it means its invalid else vaild

accordin to ur algorithm this is sequence would be true then )))((( althought its not,,!!

Originally Posted by Fatima Rizwan

accordin to ur algorithm this is sequence would be true then )))((( althought its not,,!!

put a constraint there that will check weather the ending braces are placed first or not.

Code:

#include<iostream.h>
#include<conio.h>
#include<string.h>
const int MAX=15;

class Stack
{
char array[MAX];
int top;

public:

Stack()
{
top=0;
}

void push(char a)
{
if (top<MAX)
{
array[top]=a;
top++;
}
}

char pop()
{
top--;
return array[top];
}

int isEmpty()
{
return top == 0;
}

};
class BracketChecker
{
char name[MAX];
Stack a;
  unsigned int m_stack_count;
  unsigned int m_angular_count;
  unsigned int m_square_count;
  unsigned int m_round_count;

public:
BracketChecker() : m_stack_count(0),
	    m_angular_count(0),
	    m_square_count(0),
	    m_round_count(0) {}

void input()
{
memset(name, 0, MAX);
cin>>name;
}

char* getinput()
{
return name;
}

int function()
{
for (int j = 0; j < strlen(name); j++)
{
switch (name[j])
 {
      case '{':
	a.push(name[j]);
	++m_angular_count;
      break;

      case '[':
	a.push(name[j]);
	++m_square_count;
      break;

      case '(':
	a.push(name[j]);
	++m_round_count;

      break;

      case '}':
	a.pop();
	--m_angular_count;
      break;

      case ']':
	a.pop();
	--m_square_count;
      break;

      case ')':
	a.pop();
	--m_round_count;

      break;


   }
  }
  return status();
}

int status()
 {
  int result = 0;
  if (m_angular_count != 0 ||
      m_square_count  != 0 ||
      m_round_count   != 0)
    result = 1;

  return result;
}
};

int main()
{
clrscr();
BracketChecker b;
b.input();
b.function();
int status = b.status();
if (status == 1)
cout<<"Valid\n";
else
cout<<"Invalid\n";
getch();
return 0;
}

Whatever input i give.. it says its valid,,!!