Thread: Help

You should not have that while loop in function. You need to indent your code properly so that you can trace the logic correctly - you still have that final check for whether the stack is empty inside the for loop.

If we properly format:

Code:

int function()
{
    for (int j = 0; j <10; j++)
    {
        if (name[j] =='(')
        {
            a.push(')');
        }
        if (name[j]=='[')
        {
            a.push(']');
        }
        if (name[j] == '{')
        {
            a.push('}');
        }

        if (name[j] ==')' || name[j]=='}' || name[j]==']' )
        {
            if (a.isEmpty()==0)
            {
                return 0;
            }

            if (a.pop()!= name[j] )
                return 0;
        }

        if (!a.isEmpty())
        {
            return 0;
        }
        else
            return 1;

    }
}

Now, it is obvious that this lies within the for loop:

Code:

if (!a.isEmpty())
{
    return 0;
}
else
    return 1;

Therefore, the for loop never makes it past the first iteration, i.e., it never considers any more than the first character. If that first character is an opening bracket, the stack is not empty, at the end of the loop, so it returns 0, even if the next character is a closing bracket.

But the point behind this is to check, after everything has been processed, whether the stack is empty. If at that point the stack is empty, then all is well.