Basic operator overloading question

[Swerve]

Hi there,

I'm just starting to try out Operator Overloading and wrote a basic definition for the equality operator ==.

base.h :

class Base
{
public:
	Base (int a);
	int getNo() const { return m_a; }

private:
	int m_a;
};
Base::Base(int a)
{
	m_a = a;

}
bool operator==(const Base& leftparameter, const  Base& rightparameter)
{
	leftparameter.getNo() == rightparameter.getNo();
	return true;
}

main.cpp :

#include <iostream>
#include "base.h"

using namespace std;

int main()
{
	Base obj1(1);
	Base obj2(1);

	if(obj1 == obj2)
	{
		cout << "Objects match" << endl;
	}
	else
	{
		cout << "Objects don't match" << endl;
	}
	system ("pause");
	return 0;
}

Just a basic query, Visual Studio reports:

warning C4553: '==' : operator has no effect; did you intend '='?

I'm just wondering why it says == has no effect when it does successfully compare the two objects.
I don't see why would it think I meant to assign one object to another.

Should I not worry about it? Or am I missing the point of the warning?

Thanks for any info!

[laserlight]

I'm just wondering why it says == has no effect when it does successfully compare the two objects.

You probably want to return the result of that comparison. The problem at the moment is that you compare, but you discard the results of the comparison and return true. Therefore, we can remove that comparison, and the program will still appear to behave exactly the same (other than running a little faster).

[Daved]

It successfully compares the two objects, but you ignore the result of the comparison.

The warning thinks you made a different mistake, but there definitely is something you need to fix.

[Swerve]

Ahh Ok.

bool operator==(const Base& leftparameter, const  Base& rightparameter)
{
	if(leftparameter.getNo() == rightparameter.getNo())
	{
		return true;
	}
	else
	{
		return false;
	}
}

Now I'm getting no warnings, and I'm actually using the results.

Seems to work fine now.

Thanks guys, just wanted to make sure I was getting the fundamentals right.

[laserlight]

Indeed, but you could have written:

bool operator==(const Base& leftparameter, const  Base& rightparameter)
{
	return leftparameter.getNo() == rightparameter.getNo();
}

Incidentally, lhs and rhs are sometimes used as abbreviations for "left hand side" and "right hand side" respectively for such situations as these.

[Swerve]

Thanks laserlight!

Great tips!