Thread: 2 dimensional array!!!

As of now my program as the user input an expression like *2x and then the program outputs it as

*
2
x

I am wanting to display zeros next to the elements, 2 columns of zeros so the output will be

* 0 0
2 0 0
x 0 0

This is my code

Code:

int main()
{

string s;
cout << "Input the prefix expression.\n" ;
cin >> s;
cout << "The expression tree is:\n" ;

int row = s.length();
int col = 2;
int array[row][col];
int i, j, c;

for (j = 0; j < row; j++)
for (c = 0; c < col; c++)
for (i = 0; i < s.length(); i++)
{
cout << s[i] << array[row][col] << endl ;
}

it outputs

*2293584
22293584
x2293584
*2293584
22293584
x2293584
*2293584
22293584
x2293584
*2293584
22293584
x2293584

Edit/Delete Message

Originally Posted by whitey300

Code:

int main()
{

string s;
cout << "Input the prefix expression.\n" ;
cin >> s;
cout << "The expression tree is:\n" ;

int row = s.length();
int col = 2;
int array[row][col];
int i, j, c;

for (j = 0; j < row; j++)
for (c = 0; c < col; c++)
for (i = 0; i < s.length(); i++)
{
cout << s[i] << array[row][col] << endl ;
}

it outputs

*2293584
...

Like hell it does! That cannot even compile on a conforming C++ compiler because it is using variables rather than constants for the definition of array dimensions. Even if some non-conformant compiler allows such a bazaar thing to compile as a compiler-specific language extension, then it contains a buffer overrun anyway because array[row][col] does not exist.
You know that row and col don't change right? So you're attempting to output the value of the same out of bounds array entry over and over!

I suppose you're using gcc, which has weirdo things like this?

Originally Posted by iMalc

Even if some non-conformant compiler allows such a bazaar thing to compile as a compiler-specific language extension

Bizarre, iMalc, not bazaar. Don't diss my favourite version control system

Anyway, whitey300, if you are using g++, compile with the -pedantic flag. I assume that you are already compiling with -Wall.

Originally Posted by laserlight

Bizarre, iMalc, not bazaar. Don't diss my favourite version control system

Damn, I know that too. What the hell was I thinking!