Doubly threaded link list

[mrsirpoopsalot]

I am trying to remove an item in my link list. It does have 2 threads going threw it.
headByName and headByRating.

class list
{
public:
	list(void);				// constructor
	virtual ~list(void);	// destructor
	void displayByName(ostream& out) const;
	void displayByRating(ostream& out) const;
	void insert(const winery& winery);
	winery * const find(const char * const name) const;
	bool remove(const char * const name);

private:
	struct node
	{
		node(const winery& winery);		// constructor
		winery item;
		node * nextByName;
		node * nextByRating;
	};

	node * headByName;
	node * headByRating;
};

#endif // _LIST_

What i am trying to do is remove "cooper" from the list. how can i add headByRating below so it contains all the items as headByName.

bool list::remove (const char * const name)
{

   
	node * prev = NULL;
	node * p = NULL;
	node * curr = headByName;

	
	while(curr)
	
	{

		if(strcmp(curr->item.getName(), name) == 0)
		{
		prev = headByName;
		p = prev->nextByName;
		headByName = p;
		//delete prev;
		return true;
		}
	curr = curr->nextByName;
}
return false;

cout << "\n>>> removing Cooper Mountain\n";
wineries->remove("Cooper Mountain");

I think thats all the code you would need. I just dont know how to attach the headByRating in the list with headByname in the remove function?

Thank you

[iMalc]

Remember I said that you need to duplicate the function body for the second threaded list? You need two of those while loops. One finds and unlinks the item from the nextByName list and the other finds and unlinks the item from the nextByRating list. Then you make one of those loops remember the pointer to the item that as unlinked and after both loops you delete that item.
Don't try and return from inside the loop.

[mrsirpoopsalot]

Thanks. Thats what i had previously but was told it was wrong. I ill try that and get back to you.

[mrsirpoopsalot]

This is what i have, and it appears to work. I do not know if i have a memory leak because of it though?

bool list::remove (const char * const name)
{

	node * prev = NULL;
	node * prevRating = NULL;
	node * p = NULL;
	node * d = NULL;
	node * curr = headByName;
	node * currRating = headByRating;

	while(curr)

	{
		if(strcmp(curr->item.getName(), name) == 0)
		{
			prev = headByName;
			p = prev->nextByName;
			headByName = p;
			//delete curr;
			//return true;
		}
		curr = curr->nextByName;
	}
	//return false;


	while(currRating)
	{
		if(strcmp(currRating->item.getName(), name) == 0)
		{

			prevRating = headByRating->nextByRating->nextByRating->nextByRating;
			d = prevRating->nextByRating;
			prevRating->nextByRating = d->nextByRating;

		}
		currRating = currRating->nextByRating;
	}

	prev = NULL;
	delete prev;
	d = NULL;
	delete d;
	return true;

}

[iMalc]

You're getting close. A few things:

• There should only be one delete statement, don't try and delete prev.
• You do have a memory leak, but only because you're setting a variable to NULL before calling delete.
• When you do the unlinking in each while loop, once you find and unlink the item, break out of the loop rather than iterating over the remaining items (which you know you wont need to do anything with).

[mrsirpoopsalot]

Thank you. I will take everything you said into consideration. I will break out of the loop and i already fixed the code..