Thread: Problem comparing variables

Code:

#include <iostream>
using namespace std;


int main() {
    char letter;
    char letter2;
    int num1, num2;

    main();

}

int number1() {
    cout<<"Please enter a number for number 1.\n";
    cin>> num1;
    cout<<"You've entered" << num1 << "for number 1. Is that correct?\n";
    cout<<"Press y for yes, n for no.\n";
    if (letter == y) {
        number2();
    } else {
        number1();
    }
}
int number2() {
    cout<<"Please enter a number for number 2.\n";
    cin<< num2;
    cout<<"You've entered" << num2 <<"for number2, is this correct?\n";
    cout<<"Press y for yes, n for no.\n";
    if (letter == y) {
        main();
    } else {
        number2();
    }

Now we can start looking at the code.

What you have is main() that declares a few variable, then calls itself again. main() is a special function: you don't call it, it is called for you when your program starts.

But the errors start from having undefined variables in the rest of the functions. Variables declared within a function are local to that function. These names are not visible in other functions.

Originally Posted by CrissyCrisCris

You have to get an input for letter first. Like this:

Code:

char letter[2];
cin.getline(letter, 1);
//Then compare them with strcmp()
if (strcmp(letter, "y") == 0)
     //...

If you try to run that you'll get something about main() having an int type with no return value.

If you get passed that, you will jsut be running main() in a contuinous loop. You have to call number1() and number2() from main.

Very bad example. This screams C approach. A better C++ way is:

Code:

std::string letter;
std::getline(std::cin, letter);
if (letter == "y")
     //...

Or simply

Code:

char letter;
std::cin >> letter;
if (letter == 'y')
     //...