Thread: Suggestions and question about bool pointers

Made a new thread 'cause I suspected no one would read the other one, 'cause I said it was fixed. Don't hate me, please. xP

http://codepad.org/opw4HeWp

Now, I'd like suggestions on this and is there anyway to check if a pointer, like the used pFrameFunc pointer, has been assigned anything else than 'garbage' ? Like, if it has been assigned by the code, and not some default compiler thing...

And for the suggestions, I mean would this be the right place for the loop? I don't want the users of this engine to make the loop themselves...
And I use the variable "bool& failed" as the condition for the loop, there is no problem with this? I mean, it is a pointer... Just to make me more sure about this!
Thanks in advance!

well, this constructor will be called like LIQUID* liq; then later when all is set to go, liq = new LIQUID(kinda many arguments); personally I see no flaw in this, but I've been wrong plenty before

Code:

LIQUID* liq;
SYSTEM sys;

int main(){

    sys.SetFrameFunc(SOME_DEFINED_FUNCTION());

    bool initCheck;

    liq = new LIQUID(initCheck, sys, ect...);
    if(initCheck) return true;

    return 0;
}

Just a short and fast example of how it will be called(most likely)

If I understand you correctly, I understand that you think I'm a complete retard...

The engine isn't done yet, infact far from. What that sketch showed, was how it WILL be.
Also, I've changed too much of the design for all before this post to be really 'valid' to consider once you post, or... I dunno how to explain, but the code is changed.

But I do have one question... If I call " return pFrameFunc; " does it run through pFrameFunc? Meaning, it runs the function that pFrameFunc points to ?

that's a number... Won't return need to run the function to check or something? Or do I need to make a RunFrameFunc() function too ?

EDIT: And when I posted this, I didn't have a plan to change it or anything, but I did change it after your reply, it was just so that all future posts think of that.. Well, that kinda changes the question of the topic :S

... I want to run the pointer, like, call pFrameFunc somewhere, and it runs the function which pFrameFunc points to, also the reason I asked if I was to make a new function is 'cause I amde a new class called SYSTEM which has this stuff now, and the pointers are private....

ok, thanks!

>>sys.SetFrameFunc(SOME_DEFINED_FUNCTION());
Note that this will run SOME_DEFINED_FUNCTION and pass what is returned from that function to SetFrameFunc.
If you want to assign a function pointer, then take its address instead of calling it:
sys.SetFrameFunc(&SOME_DEFINED_FUNCTION);

2nd) I don't think it's a good idea the for constructor to block. Not at all. The constructor should only initialize the object, making it ready for use. Create some other function, such as Run, which can block.

3rd) I believe it's a better idea to throw an exception is the constructor fails rather than return a failure. Your approach just says it "failed", as well, but not why, which is not very helpful.

First I make it work, then I make it awesome

That said, though, it's usually not too helpful to go the "wrong way" too far since it will end up costing more time to make the "correct" changes.
Like throwing an exception - just a simple one can't be too much work for the basic code.