Thread: plzzz!!! answer this c++proggram on how to use do,while code?

First learn to indent properly.

Originally Posted by cpjust

First learn to indent properly.

It doesn't help that some instructors don't bother to even mention indentation, much less talk about doing it properly.

Originally Posted by Black Diamond

do is for looping and while is for condition to stop and show any action .
Example :

Code:

do {
     x=x+1;
     // It loops continuous until it stop through while condition.
}
while(x>=5);{
   cout<< "you have reach on 5";
}

your indentation suxxes big deal

Code:

do {
     x=x+1;
     // This loop continuous while condition is true.
} while(x>=5);

cout<< "x value has exceeded 5";

Code:

#include <iostream>
#include <string>

using namespace std;

double addition ( double x, double y );
double subtraction ( double x, double y );
double multiplication ( double x, double y );
double division ( double x, double y );

int main ( ) 
{
    string thePassWord = "frozon";
    string changePassWord = "fire";
    string passWord;
    char myChoice;
    double x, y;
    int count = 0;
    
               
    do {
        
         cout << "Enter password: \n>";
         getline ( cin, passWord, '\n' );
         
         count++;
         
         if ( count == 3 ) 
         {
              cout << "Error: You enter the password wrong 3 time. \n";
              cout << "Password is being changes. \n";
              
              thePassWord.swap (changePassWord);
              
         }
         
        } while ( passWord != thePassWord );
                
    if ( passWord == thePassWord ) 
    {
         while ( true ) 
         {
             cout << "Select your choice: \n";
             cout << "Select \'a\' for addition: \n";
             cout << "Select \'s\' for subtraction: \n";
             cout << "Select \'m\' for multiplication: \n";
             cout << "Select \'d\' for division: \n>";
             
             cin >> myChoice;
             
             switch ( myChoice ) 
             {
                    case 'a':
                    case 'A':
                         
                         cout << "Addition: \n";
                         cout << "First number: \n>";
                         cin >> x;
                         cout << "Second number: \n>";
                         cin >> y;
                         
                         cout << endl;
                                    
                         cout << x << " + " << y << " = " << addition ( x, y ) << "\n\n";
                         
                         cin.get();     
                         break;
                     
                    case 's':
                    case 'S':
                         
                         cout << "Subraction: \n";
                         cout << "Frist number: \n>";
                         cin >> x;
                         cout << "Second number: \n>";
                         cin >> y;
                         
                         cout << endl;
                         
                         cout << x << " - " << y << " = " << subtraction ( x, y ) << "\n\n";
                         
                         cin.get();
                         break;
                         
                    case 'm':
                    case 'M':
                         
                         cout << "multiplication: \n";
                         cout << "First number: \n>";
                         cin >> x;
                         cout << "Second number: \n";
                         cin >> y;
                         
                         cout << endl;
                         
                         cout << x << " * " << y << " = " << multiplication ( x, y ) << "\n\n";
                         
                         cin.get();
                         break;
                         
                    case 'd':
                    case 'D':
                         
                         cout << "division: \n";
                         cout << "First number: \n>";
                         cin >> x;
                         cout << "Second number: \n>";
                         cin >> y;
                         
                         cout << endl;
                         
                         if ( y == 0 ) 
                         {
                              cout << "Error: \n\n";
                              
                              continue;
                         }
                         
                         cout << x << " / " << y << " = " << division ( x, y ) << "\n\n";
                         
                         cin.get();
                         break;
                         
                    default:
                            
                            cout << endl;
                            
                            cout << "Error: Invalid Choice. \n\n"; 
                            
                            cin.get();
                            break;
             }
        }     
    }
    
    cin.get();   
    return ( 0 );
    
}
    
double addition ( double x, double y )
{
       return x + y;
}

double subtraction ( double x, double y )
{
       return x - y;      
}

double multiplication ( double x, double y )
{
       return x * y;
}

double division ( double x, double y )
{
       return x / y;
}

Just an idea........

Originally Posted by Cathalo

What they mean by indentation is that your code is broken up nicely so that it is easier to read.Like below its easier to see when varibles are being initialised and so on

Code:

#include<iostream>
#include<string>

int main(){

int someVar=0;
int anotherVar=1;
int userInput;

switch(userInput){
                     case 1:
                                cout<<userInput<<endl;
                                break;

                      case 2:
                                 cout<<userInput<<endl;
                                 break;
      }
return 0;
}

I have only started out programming but if your code is presented so that other people can read it easily the programmers on this site are quick to answer either telling you where you went wrong or at least point you in the right direction.

also where varibles have 2 (or more)words,capitalise the 2nd words first letter,it makes it the varible name standout more

This isn't proper indentation either.
Sshakey6791 got the indentation right.

I probably would have used an array of function pointers, or, since this is C++, a std::map -- oh, and I definitely would have used tolower() -- but neither my solution nor yours is going to help the OP very much I would think. What are the chances someone is familiar with functions if they are not familiar with do-while loops?

With that in mind, here are some links:

• http://www.cprogramming.com/tutorial/lesson3.html -- a tutorial on loops
• cpwiki.sf.net/Void_main -- why void main() is bad

One thing to note in Sshakey6791's code: it's a good idea to do as they have done and check for division by zero to avoid a segmentation fault . . . .

BTW, "qoutient" is spelled "quotient". And you could reuse a "result" variable in your code instead of declaring sum, difference, etc.

[edit]

Sshakey6791 got the indentation right.

More or less. This looks a little suspect to me.

Code:

    do {
        
         cout << "Enter password: \n>";
         /* ... */
         
        } while ( passWord != thePassWord );

But Sshakey6791 certainly knows what to do. That's probably just his/her style.
[/edit]