Thread: strstr() Runtime Error - HELP!

i have made this strstr() function,it gives the correct answer if it finds the correct string inside the another but the program crashes if it does not find the string,gives a runtime error,compliler does not give any error!

here is my code:

Code:

char *astrstr(const char *s1,const  char *s2)
{
	char *p=NULL;

	int x=astrlen(s1);
	int y=astrlen(s2);

	int o=0,z=0;
	for(int i=0;i<x; i++)
	{
		for(int k=0;k<y;k++)
		{
			if(s1[i]==s2[k])
				{	o=0;z=0;	
						for(int l=i;l<x;l++)
						{
							if(s1[o+i]==s2[o])
							{
								z++;
							}
							o++;
						}
			
			
				}
				
				if(z==y)
					{
						return (char *)(s1+i);
				
					}
		}
	}
return p;
	
}

int _tmain(int argc, _TCHAR* argv[])
{
	char s[]={"this is a simple string"};
	char t[]={"is"};
	cout << " S: "<< s << endl << " T: "<< t << endl << endl;
	
	cout  << "My Function: " << endl <<  astrstr(s,t) << endl << " String Function : " << endl << strstr(s,t) << endl  << "S: "<< s << endl << "T: "<< t << endl;
	
	
	
	return 0;
}

You seem to have quite a few loops inside each other, more than what I expected.

I'm fairly sure you go over the end of the string in this bit:

Code:

						for(int l=i;l<x;l++)
						{
							if(s1[o+i]==s2[o])
							{
								z++;
							}
							o++;
						}

o will be x-1, and if i = x-1 (which happens at the end of the string), then s[o+i] is way beyond the end of the string.

I also think you need to break the loop if s1[o+i] != s2[o] and start over at the beginning of s2. Otherwise, strsrt("AaBbCc", "abc") will return &s1[1];

Some minor code review comments:

Code:

						return (char *)(s1+i);

No need for a cast here.

Code:

	char *p=NULL;
...
return p;

p is never set to anything other than NULL, so why not just return NULL?


--
Mats