Thread: Deleting memory

I allocated memory and i forgot to delete it at the end and then i compiled it.
Then i realized my mistake and deleted it and recompiled the program.
But it keeps giving me the same result as before having not deleted it.
Even if i restart my system it wont compile with the changed code.
Whats the deal with this? Its not the first time that it happens to me.
Isnt memory freed when you close a program even if you didnt freed it in your program?

Code:

#include <iostream>
using namespace std;


int *pPointer;

void SomeFunction()
{
    // make pPointer point to a new integer

    pPointer = new int;
    
    *pPointer = 25;
}

int main()
{
    cout<< "Value of *pPointer before:"<< *pPointer <<endl;
    
    SomeFunction(); // make pPointer point to something

    cout<< "Value of *pPointer after: "<< *pPointer <<endl;
    
    delete pPointer;

    system ("pause");
}

Well, you use *pPointer (i.e. dereference pPointer) before setting it to anything. However, since pPointer is a global variable, it will be initialized to all zeros -- so in effect, you're dereferencing a NULL pointer. (I've seen compilers that generate executables which detect this, but most do not.)

I'm wondering if you meant to use something like this . . .

Code:

#include <iostream>
using namespace std;


int *pPointer;

void SomeFunction()
{
    // make pPointer point to a new integer

    pPointer = new int;
    
    *pPointer = 25;
}

int main()
{
    cout<< "Value of pPointer before: "<< pPointer <<endl;
    
    SomeFunction(); // make pPointer point to something

    cout<< "Value of pPointer after: "<< pPointer <<endl;
    printf("Value of *pPointer after: %d\n\n", *pPointer);
    
    delete pPointer;

    system ("pause");
}

Oh, and why are you using cout some of the time, and printf() some of the time? You're either using C or C++ (probably C++ since you're also using new and delete) -- don't use both if you can help it.

Also, see the FAQ for alternatives to system("pause"), which I dislike.

Originally Posted by Ducky

Even if i restart my system it wont compile with the changed code.

Your example program compiles for me, but if it does not compile, it could be because you did not #include <cstdlib> for std::system().

Originally Posted by Ducky

Isnt memory freed when you close a program even if you didnt freed it in your program?

Generally, yes, the operating system will reclaim the memory allocated to the process.

By the way, this results in the dereferencing of a null pointer:

Code:

cout<< "Value of *pPointer before:"<< *pPointer <<endl;

Incidentally, instead of this:

Code:

pPointer = new int;

*pPointer = 25;

you can write:

Code:

pPointer = new int(25);

But then you should not be using a global variable; you can pass the pointer by reference instead.

Thank you Dwks!

Well, you use *pPointer (i.e. dereference pPointer) before setting it to anything.

I set it to 25 in the function.
Or main() dont see the memory allocated in the function if you dont call the function itself?

And even if i change it to your version it wont compile (it compiles the old code )

Originally Posted by Ducky

I set it to 25 in the function.

Yes, but you call the function after dereferencing the pointer.

Originally Posted by Ducky

Or main() dont see the memory allocated in the function if you dont call the function itself?

Since pPointer is global, it has static storage duration and is thus zero initialised, hence it is a null pointer when control enters the global main() function.

Originally Posted by Ducky

And even if i change it to your version it wont compile (it compiles the old code )

That sounds like a problem with your development environment rather than your code per se. You might want to start over with a new project if you are unable to fix this problem.

Thank you Laserlight!

Yes, but you call the function after dereferencing the pointer.

Why would this be wrong?
Dereferencing wont change anything it just looks at the value stored at its address.
Isnt it?

Originally Posted by Ducky

Why would this be wrong?
Dereferencing wont change anything it just looks at the value stored at its address.

So, what is the address contained in pPointer before you call SomeFunction()?

lol You got me! There is none.

So i got to point it to somewhere first. Thanks!

Originally Posted by Ducky

lol You got me! There is none.

So i got to point it to somewhere first. Thanks!

Yes. And it being a global or local makes no difference here - if it's global it contains NULL, if it's a local, it contains whatever happened to be at that address, which is quite possibly completely meaningless as a pointer (e.g. some text, remnants of a floating point number), but it CAN be a valid memory address!

--
Mats

Thanks Matsp!

I changed the code, its working now.

Also, see the FAQ for alternatives to system("pause"), which I dislike.

With system() its easy to close your program.

Code:

#include <iostream>
#include <cstdlib>
using namespace std;

int  x;
int *pPointer = &x;

void SomeFunction()
{
    // make pPointer point to a new integer

    pPointer = new int;
    
    *pPointer = 25;
}

int main()
{
    cout<< "Value of *pPointer before:"<< *pPointer <<endl;
    
    SomeFunction(); // make pPointer point to something

    cout<< "Value of *pPointer after: "<< *pPointer <<endl;
    
    delete pPointer;

    system ("pause");
}