Thread: no match for 'operator<=' in 'qual1

No, you are not. You are trying to store input into an array, without specifying WHERE in the array you want to store it, and you are especially not writing to the file.
And you really MUST fix your indentation!

Does that compile?

Assuming you were reading into part[i], then your loop goes from 1 to 5, which is outside the range of 0..3 that part[4] allows you to use.

--
Mats

After looking at it again, I realize why it compiles: You are reading a string - char part[4] is a string in C (and thus C++). So you are not actually reading into an array (in the general meaning of array - strictly speaking, C style strings are of course arrays, but that's not what any of use meant when we said "use an array"). Of course, in this case, you are just outputting what you input, so it doesn't really matter how you read it in - using arrays would not really mean much in THIS case - as long as you don't enter anything longer than 3 digits or letters, as the array is 4 characters long, and you need a zero-character at the end of the string.

And as to the index of an array with n elements: You write that as

Code:

T arr[n]

(T is any valid type, n is some integer constant type). You then have valid valuse for [x] in the range 0..n-1. So

Code:

int array[4];

will have four elements, with the index 0, 1, 2 and 3. Note that what you write in the declaration of the array is THE NUMBER OF ELEMENTS, and then use the indices up to one less than the number of elements.

--
Mats

cin >> array1[n];
Where n is the index in the element to store the result.

And fix your indentation already!!

And you still have a loop that goes TWO places outside of the array, if you use [i] as the index when reading the input. This is because you start on 1 and end on 5, whilst your array has elements 0..3.

--
Mats

But you are not listening to what we say!
You have YET to fix the indentation.
And you have YET to fix the loop itself!
Go back and read the previous replies before you do anything more, and before you reply, fix everything that the previous replies mentioned.

After you've done that, I will tell you what's wrong with the code.

So, first of all 'n' that Elysia talks about is "a number indicating which element in the array you are referring to". In your case, n is a new variable, and it's got no value at all - bad idea. You probably want to use i, rather than n.

Second, part is supposed to be a text string, which is an array of char in itself.

Third. why are you using anonymous names such as array1 and array2 - much better to call them something that reflect what the actual content is.

Fourth, what is the purpose of loading the values in an array when you are just storing it to write out again?


--
Mats

Is it somehow impossible for you to read some lines in a reply?

what do you want me to do indent it until you cant see the code on the screen

Originally Posted by rfoor

what do you want me to do indent it until you cant see the codehttp://cboard.cprogramming.com/images/icons/icon10.gif

No, just so that the code is readable.

--
Mats

Is that what you call indentation?
I call this indentation:

Code:

if (qual[0]<=150){
    cout<<"Reorder 200 of part "<<part<<endl;
    total=cost[0]*200;
    cout<<"Total reorder cost:$"<<total<<endl;
}
                  
if (qual[1]<=250){
    cout<<"Reorder 300 of part "<<part<<endl;
    total=cost[1]*300;
    cout<<"Total reorder cost:$"<<total<<endl;
}
                  
if (qual[2]<=115){ 
    cout<<"Reorder 150 of part "<<part<<endl;
    total=cost[2]*150;
    cout<<"Total reorder cost:$"<<total<<endl;
}
                   
if (qual[3]<=435){
    cout<<"Reorder 500 of part "<<part<<endl;
    total=cost[3]*500;
    cout<<"Total reorder cost:$"<<total<<endl;
}
                  
if (qual[4]<=250){
    cout<<"Reorder 750 of part "<<part<<endl;
    total=cost[4]*750;
    cout<<"Total reorder cost:$"<<total<<endl;
}

And another snippet:

Code:

#include<iostream>
#include<cstring>
#include<fstream>

using namespace std;
using std::string;


int main(){
	char part[4];
	char des[4];
	char qual[4];
	char cost[4];
	char total[4];
	int x;
	fstream file("Part.txt",ios::out);


	for(x=1;x<=5;x++){
		cout<<"Part Number:";
		cin>>part;
		file<<part<<endl;
		cout<<"Part Description:";
		cin>>des;
		file<<des<<endl;
		cout<<"Quality on Hand:";
		cin>>qual;
		file<<qual<<endl;
		cout<<"Unit Cost:";
		cin>>cost;
		file<<cost<<endl;
	}



	file.close();
	system("pause");
	return 0;
}

This is by no means good looking code, but at least it's readable.