Thread: what could be wrong with this loop!?

well, i dont really understand , this is supposed to work! by the loops seem to not be working!

Code:

        void CLA::machinLanguageConvertor()
        {
                string temp = commandnameptr;
                int argument = 0;
                if ( commandnameptr != "not needed" )
                {
                        argument = Atoi(offsetptr);
                        offsetptr = Oct2Bin( argument );

               
                if ( (temp != "INX") || (temp != "LAX" ) || (temp != "LDA")|| (temp != "DEX") || (temp != "CLX" ) )
                {
                        CommandsBinaryString = BinaryDetector( commandnameptr );
                        CommandsBinaryString.append(mixstateptr);
                        CommandsBinaryString.append(offsetptr);

                }

                }
                
                
                 else  
                {
                        CommandsBinaryString = commandnameptr;
                }
                
                cout<<"\nBinary Instruction = "<<CommandsBinaryString;

        }

i expect the out put as when command name ptr is INX, it should skip the offset and MIX stat ptr initialization! and just print the INX retrived binary!
but when it comes to INX, it adds the offset to the end of the string , meaning it runs

Code:

	
Code:
	
  
                if ( (temp != "INX") || (temp != "LAX" ) || (temp != "LDA")|| (temp != "DEX") || (temp != "CLX" ) )
                {
                        CommandsBinaryString = BinaryDetector( commandnameptr );
                        CommandsBinaryString.append(mixstateptr);
                        CommandsBinaryString.append(offsetptr);

                }

                }

which it should skip! what is wrong ?
and i think it doesnt even run the first if statement! (it sikps it!)

many thanks bro.
i meant if one of them is wrong ! just exit!
i should make those && ! yes?

Originally Posted by R.Stiltskin

Your indentation is confusing. Do you really intend that the second "if" is inside the first "if" block, and the "else" refers to the first "if"?

well the second if is inside the first if , and the else refers to the second if !

Code:

               if ( temp != "not needed" )
                {
                        argument = Atoi(offsetptr);
                        offsetptr = Oct2Bin( argument );


                        if ( (temp != "INX") && (temp != "LAX" ) && (temp != "LDX") && (temp != "DEX") && (temp != "CLX" ) )
                        {
                                CommandsBinaryString = BinaryDetector( commandnameptr );
                                CommandsBinaryString.append(mixstateptr);
                                CommandsBinaryString.append(offsetptr);

                        }

///Error .Inx kar nemikonan.

                        else
                        {
                                CommandsBinaryString = commandnameptr;
                        }
                }

by the way ! the first error i used to get is gone! by changing || to && . but it seems now the second else is not functioning ! how am i supposed to attach that if with this else !?

Originally Posted by Masterx

well the second if is inside the first if , and the else refers to the second if !

The problem is that in your original code the else is associated with the first if.

Originally Posted by laserlight

The problem is that in your original code the else is associated with the first if.

tanx .

Originally Posted by R.Stiltskin

... and if your revised code is what you intended, you can replace

Code:

else if ( (temp == "INX") || (temp == "LAX" ) || (temp == "LDX")|| (temp == "DEX") || (temp == "CLX" ) )
{

with

Code:

else
{

tanx , i did tha , is it supposed to connect the second if and the else ? !
( i did it . but im still getting none sense here . )
snapshot.JPG
========================
i have two kind of commands :
1 plain commands
2 commands stating a specific addressing mode.(complex commands)
========================
i the following loop, i search for both commands, there is a difference the complex commands dont need the offset and M.I.X (which is an addressing mode indicator)
========================
so , when the command is recognized! the BinaryDetector() function takes the command name , and analyzes it , and then retrieve the commands binary representation!. if it is aplain command , it would be merged with mix and offset.
if not it should be either (INX, or DEX, or LDX, or LAX or ,CLX) . and its binary representaion should be retrieved!
========================

well i just dont know why it doesnt do it right!
========================
note : that first if is to eliminate declaration instrcutions, i mean because each time one string representing one instruction is taken under analysis , this is to avoid further error! because declaration are not executive commands, they just represents offsets! so the must not get into this session and accidantaly get into the memory!
each declaration when recognized in tokenizer() ( a function before this) would contain "not needed" string as its command name and also its offset value!
so by using this trick i can recognize it from other actual commands.
thats the reson its up there !

hope this intruductory helps you understand what i meant by doing such a thing

thank you all for you time and answers.

no idea what im doing wrong?!

so whats wrong with the modified one!( edited the if else ! )

are the condition checks ok ? ? what about this one ?

Code:

        void CLA::machinLanguageConvertor()
        {
                string temp;
                temp = commandnameptr;
                int argument = 0;


                if ( temp != "not needed" )
                {
                        argument = Atoi(offsetptr);
                        offsetptr = Oct2Bin( argument );


                        if ( (temp != "INX") && (temp != "LAX" ) && (temp != "LDX") && (temp != "DEX") && (temp != "CLX" ) )
                        {
                                CommandsBinaryString = BinaryDetector( commandnameptr );
                                CommandsBinaryString.append(mixstateptr);
                                CommandsBinaryString.append(offsetptr);

                        }

///Error .Inx wont work.

                        else
                        {
                          
                                 CommandsBinaryString = commandnameptr;
                        }
                }
                cout<<"Binary Instruction = "<<CommandsBinaryString;

        }

Originally Posted by tabstop

This:

Code:

if ( (temp == "INX") || (temp == "LAX" ) || (temp == "LDX")|| (temp == "DEX") || (temp == "CLX" )

is completely redundant, as was pointed out to you before (apparently futilely). The only possible way to get into the else is for temp to equal one of those five strings. Therefore the check must be true, so don't do it.

The only problem here is when temp does equal "not needed", as then the last cout will happen and Binary Instruction = garbage will get printed out.

i dont underrstand ! is it not a (OR) ? and when i use OR if one of them appears there ( is recognized) it should enter the block, if none of them is recognized , so wont enter the block!
i meant it by using or, those for are complex commands, and need to only contain command , no offset and mix. as you've mentioned !

The only possible way to get into the else is for temp to equal one of those five strings.

and i want this to happen!
and about Binary instruction ! :Binary instruction is initialized in the upper function! it is printed there !still you think the "not needed" is the problem /?