Thread: Help me solve this programming error please

I have created the following code and I need some guidance on how to correct my error. The code is as follows:

Code:

#include <string>
#include <iostream>
#include <fstream>
#include <cstdlib>
using namespace std;

const int MAX_BOOKS = 2000;
const int MAX_USERS = 500;

struct User
{
    string userID;
    string name;
    string houseNo;
    string address;
    string noOfLoans;
};

struct Book
{
    string bookID;
    string title;
    string authorSurname;
    string authorFirstname;
    string category;
    string location;
    string onLoan;
};

enum  bookCategory 
{
    Adventure = 'A', 
    Detective = 'D', 
    SciFi = 'S', 
    Romance = 'R'
};

int findBookAuthor(Book[], string, int);

int main()                                         
{


    ifstream bookDataFile;
    ifstream userDataFile;
    Book books[MAX_BOOKS];
    User users[MAX_USERS];
    int noOfBooks = 0;
    int noOfUsers = 0;
    bookDataFile.open("bookdata.txt");            
    userDataFile.open("userdata.txt");    

while(!bookDataFile.eof() && noOfBooks < MAX_BOOKS) 
    { 
        getline(bookDataFile, books[noOfBooks].authorSurname);
        getline(bookDataFile, books[noOfBooks].authorFirstname);
        getline(bookDataFile, books[noOfBooks].title); 
        getline(bookDataFile, books[noOfBooks].category);
        getline(bookDataFile, books[noOfBooks].bookID);
        if (! bookDataFile.eof())      
              noOfBooks++;
    }

bookDataFile.close();

    string author;
    int bookID;
    int option;
    while(true)
    {
        cout << "1. Loan Book" << endl;
        cout << "2. Find Book By Author" << endl;
        cin >> option;
        switch(option)
         {
            case 1:
                cout << "Under Construction" << endl;
            break;

            case 2:
                cout << "Enter Author Name: ";
                cin >> author;
                bookID = findBookAuthor(books, author, noOfBooks);
            break;
         }
    }    
    
    return 0;
}

int findBookAuthor(Book books[], string author, int noOfBooks)
{
    for(int bookNo = 0; bookNo < noOfBooks; bookNo++)
    {    
        if(books[bookNo].authorSurname == author)
        {
            cout << "--------------------------------------------------" << endl;
            cout << "BookID: " << books[bookNo].bookID << endl;
            cout << "Title: " << books[bookNo].title << endl;
            cout << "Author: " << books[bookNo].authorSurname << "," << books[bookNo].authorFirstname<< endl;
            cout << "Category: " << books[bookNo].category << endl;
            cout << "Location: " << books[bookNo].location << endl;
            cout << "onLoan: " << books[bookNo].onLoan << endl;
            cout << "--------------------------------------------------" << endl << endl;        
        }    
    }
    return -1;
}

int findUser(User users[], string userName, int noOfUsers)                 
{
    for(int userID = 0; userID < noOfUsers; userID++)
    {    
        if(users[userName].name == users)                                                                 
        {
            cout << "--------------------------------------------------" << endl;
            cout << "UserID: " << users[userID].userID << endl;
            cout << "Name: " << users[userID].name << endl;
            cout << "House No: " << users[userID].houseNo << endl;
            cout << "Address: " << users[userID].address << endl;
            cout << "No of Loans: " << users[userID].noOfLoans << endl;
            cout << "--------------------------------------------------" << endl << endl;  
        }    
    }

    return -1;
}

The error I am getting is around this area:

Code:

for(int userID = 0; userID < noOfUsers; userID++)
    {    
        if(users[userName].name == users)                                                                 
        {
            cout << "--------------------------------------------------" << endl;
            cout << "UserID: " << users[userID].userID << endl;
            cout << "Name: " << users[userID].name << endl;
            cout << "House No: " << users[userID].houseNo << endl;
            cout << "Address: " << users[userID].address << endl;
            cout << "No of Loans: " << users[userID].noOfLoans << endl;
            cout << "--------------------------------------------------" << endl << endl;  
        }    
    }

    return -1;

And the error message I am receiving is:

Code:

In function `int findUser(User *, basic_string<char,string_char_traits<char>,__default_alloc_template<false,0> >, int)':
library.cc:114: no match for `User *&[string &]'

Can someone please guide me on how to fix this problem, thanks in advance.

Sorry I require more help than this.

look at the variable you're using to index your array in that if statment. I think you'll find that it's not compatible with the type of variable that C++ would normally expect for an array index.

Originally Posted by Elkvis

look at the variable you're using to index your array in that if statment. I think you'll find that it's not compatible with the type of variable that C++ would normally expect for an array index.

So what should be there instead? Sorry I can't exactly understand it, just feeling a little ill and can usually correct these things, but today I just want someone to help me so I can get on with the rest of it when I am better.

Originally Posted by rushhour

So what should be there instead? Sorry I can't exactly understand it, just feeling a little ill and can usually correct these things, but today I just want someone to help me so I can get on with the rest of it when I am better.

I realize twomers has a Calvin and Hobbes avatar, but you should probably pay attention to what the man says anyway.

Originally Posted by twomers

>> users[userName]
users is an array accessed by a number. userName is a string. Should be users[userID], I'd imagine.

Also, it might be worth using vectors instead of arrays. They're expandable arrays, not limited to the bounds you set at the start.

Can you please help me with a solution to solve this problem them. I'm sorry but I don't want to use vectors, I at least want to try solving the problem this way before using vectors. I also tried it using users[userID] and it hasn't work.

Thanks if you can help.

Originally Posted by rushhour

Can you please help me with a solution to solve this problem them. I'm sorry but I don't want to use vectors, I at least want to try solving the problem this way before using vectors. I also tried it using users[userID] and it hasn't work.

Thanks if you can help.

Did you also manage to change ==users into ==userName?

Thanks it works now, but now I am getting a further problem. Every time I enter an author's name in the format Brook, Frederick it seems that the program goes into a continuous mode of displaying the menu options until i press control D to stop it.

Any ideas on how to solve this?

Thanks if you can help.

Originally Posted by rushhour

Thanks it works now, but now I am getting a further problem. Every time I enter an author's name in the format Brook, Frederick it seems that the program goes into a continuous mode of displaying the menu options until i press control D to stop it.

Any ideas on how to solve this?

Thanks if you can help.

Use a real input mechanism, as opposed to >> (that is, at least use something that can handle spaces).

Originally Posted by tabstop

Use a real input mechanism, as opposed to >> (that is, at least use something that can handle spaces).

And what would that be? (sorry I'm asking alot, my illness doesn't help me concentrate, but i'd rather get it done now)

Originally Posted by rushhour

And what would that be? (sorry I'm asking alot, my illness doesn't help me concentrate, but i'd rather get it done now)

Well, you used getline elsewhere; why not here?

Originally Posted by tabstop

Well, you used getline elsewhere; why not here?

Ok thanks, I did use this, but I honestly forget how to use this getline command can you tell me how to use this to solve the problem of continuing to display the menu options untill i press control d?

Thanks if you can help.

Originally Posted by rushhour

Ok thanks, I did use this, but I honestly forget how to use this getline command can you tell me how to use this to solve the problem of continuing to display the menu options untill i press control d?

Thanks if you can help.

You could look back at your very own program and read it (after all you wrote it, right?) to see how to use getline.