Thread: Help in strings

Hello all. Getting to the point, I need some help in string functions. I was making a program to implement my own string functions, without using string.h
The program turns out proper and correct, but one little flaw remains and that appears in the execution. For this snippet of code -:

Code:

 cout << "\nEnter 2 strings - ";
gets(str1);
fflush(stdin);
gets(str2);
fflush(stdin);

The computer accepts only one string and not the other. Why is this so? Even if I try

Code:

cout << "\nEnter 1 string - ";
gets(str1);
fflush(stdin);
cout << "\nEnter 2nd string - ";
gets(str2);
fflush(stdin);

It doesn't work. Will be grateful if you help ASAP.

Maybe your implementation of gets() is wrong. Oh wait, why bother implementing the terribly unsafe gets() in the first place? Have you considered designing and implementing a cleaner version of std::string instead?

By the way, fflush(stdin) results in undefined behaviour. There are other ways to "flush" the input buffer that do not result in undefined behaviour; see the cprogramming.com FAQs.

Hmm..I checked that. Then I suppose this is how I would go about it -:

Code:

cout << "\nEnter 2 strings - ";
int ch;
char buf[BUFSIZ];
while((ch = cin.get()) != '\n && ch != EOF);
        {
            gets(str1);
            cout.flush();
            gets(str2);
            cout.flush();
        }

Edit : Ah yes its working now. Thanks a bunch!

Let me guess - there is a scanf/cin >> to read a number before this function - so your clearing of the input buffer allows the left-over newline that was in the input buffer to be cleared. This would be the 112th time someone has posted about this since I joined the forum.

--
Mats

And you are still using gets.
Get rid of it.
http://cpwiki.sourceforge.net/Gets

std::string str;
std::getline(std::cin, str);