Thread: try & catch

I've got this code (it is only part of my code):

Code:

int main(void) {

   ifstream fin("myfile.txt");
   string line;
   int counter=0;

   string nameMainDir; //it contains line " Directory: C:\root"
   //where 'Directory' is word dependent on language version of dir/s
   //and 'root' is the name of main directory in our tree
   string root; //it contains only name 'root'

//...

      try
      {
         if (counter==0) //if it is first iteration, it reads nameMainDir
         {
            nameMainDir = line; //it reads first line
            size_t size;
            size=line.size(); //here I check size of the line
            int i=size;
            do { i--; } while (line[i]!=(char)92); //it counts from end of line
                                                //to first use of symbol char(92)=='\'
            root=line.substr((i+1),(size-i)); //if writes name of root directory                                      
            counter++; //it disables entering this if any more
         }
      }
      catch(FirstLineIsEmpty)
      {cout<<"there was error";}

}

and I want this 'catch' to be executed if the first line is empty - but I don't know how to do it.

That's not really the best use of exceptions. Normally you want to use exceptions where the error needs to propagate up to calling functions to be handled later. Here, you're creating the exception and handling it in the same place. A simple if statement should be all you need.

If you want to use exceptions anyway, then you have to figure out what you want to throw. Normally you would use an existing exception class or write your own. Something as simple as this would work:

Code:

class FirstLineIsEmpty { };

You still need an if, but if the line is empty you throw FirstLineIsEmpty;. The catch should be catch (FirstLineIsEmpty& ).

I heard that using exceptions is if I've got situation which shouldn't happen and probably won't happen at all - this is why we call it exception. I don't use 'if' because I guess it will never happen. I expect first line to be non-empty line but if it happens that this line is empty, I want to use this exception. This exception should write information "There was an error. Do you want to continue execution of the program?" and write short explanation of the reason of this error (how to avoid it in the input file so that the user can edit .txt file by his/her own). And simply I don't know how to write this catch .

>> I heard that using exceptions is if I've got situation which shouldn't happen and probably won't happen at all - this is why we call it exception. <<

That is true, but is only part of the equation. Another part is that you shouldn't use exceptions if a simple if statement will suffice. You should just use an if here. Separate the error message into a separate function if you'd like:

Code:

if (line.empty())
{
    outputEmptyLineErrorMessage();
    return 1; // or whatever you want to return
}