Thread: copying differents maps

Originally Posted by Daved

>> Wow, horrible code for something that should be something so easy. <<
This type of comment is useless (or worse) without an explanation or other example. Although if you'd care to start a discussion about it I'd hope it doesn't derail the thread.

I changed the code (see above, red color).
It's quite enlightening to clearly see what's going on.
I had a very difficult time trying to understand the code cpjust originally posted. Splitting it like that helped a lot.
(I hope it is of benefit to someone.)

OK, how's this formatting instead?

Code:

	for ( mapStrSet::iterator it = map_str_set.begin(); it != map_str_set.end(); ++it )
	{
		map_str_vector.insert( mapStrVector::value_type( it->first,
								 std::vector<std::string>( it->second.begin(),
											   it->second.end() ) ) );
	}

That's usually how I'd format it when I'm not in a hurry.

I just wish this site used tabs that were 4 spaces wide, so I wouldn't have to fix it when copying from VC++ to here.

Originally Posted by Daved

>> I changed the code (see above, red color). <<

Did you only change the spacing? Calling something "horrible code" implies that more than just formatting is bad. And BTW, I prefer cpjust's formatting when actually writing such code (although not when posting to the forum).

Yeah, I meant that it's so much complexity for something that sounds so easy. That's what I meant with horrible.
Btw, I contracted the spaces to make it more compact.

Originally Posted by cpjust

OK, how's this formatting instead?

Code:

	for ( mapStrSet::iterator it = map_str_set.begin(); it != map_str_set.end(); ++it )
	{
		map_str_vector.insert( mapStrVector::value_type( it->first,
								 std::vector<std::string>( it->second.begin(),
											   it->second.end() ) ) );
	}

That's usually how I'd format it when I'm not in a hurry.

I think it's slightly better, but I prefer to separate the arguments myself.
Since insert is a function, I put its arguments on new lines.
And if there's just one or max two arguments dependant on each other, I put them all on a single row.
It makes it so much easier to see what ) and ( which belongs to where and what arguments function X and function Y takes.

I just wish this site used tabs that were 4 spaces wide, so I wouldn't have to fix it when copying from VC++ to here.

Now there's something we agree on!
Btw, I never really commented on your style. You are one of the few who write code the way I do and like