Thread: enum and int

Hello

I have a simple enumeration:

Code:

enum simple {
	one = 1,
	two,
	three
};

Now I want to compare enum with integer.

Code:

bool compare(simple e) {
	int someint = 2;
	return (someint == e) ? true : false;
}

Is this a proper way of doing this or it would be better to cast simpe enum to int (with static cast) before comparing it with integer:

Code:

int casted = std::static_cast<int>(e);

where e is simple enum datatype.

Many thanks in advance!

Because I story http response/reply header this way:

Code:

  enum status_type
  {
    ok = 200,
    created = 201,
    accepted = 202,
    no_content = 204,
    multiple_choices = 300,
    moved_permanently = 301,
    moved_temporarily = 302,
    not_modified = 304,
    bad_request = 400,
    unauthorized = 401,
    forbidden = 403,
    not_found = 404,
    internal_server_error = 500,
    not_implemented = 501,
    bad_gateway = 502,
    service_unavailable = 503
  } status;

which I think its the best way of doing it. And then I have to compare it with the integers which are parsed out of the data.

Shouldn't you be storing your responces into a status_type anyway? Its valid in C++ to store things to a status_type using istreams or however you are processing your HTTP requests.

If you create your enum 'status_type' , you probably want to compare a variable to the values you've defined. So you should compare that variable with your enum, that's what it is ment for.

Originally Posted by MarkZWEERS

If you create your enum 'status_type' , you probably want to compare a variable to the values you've defined. So you should compare that variable with your enum, that's what it is ment for.

So by that definition its legal and okay to compare int with enum without casting it to enum?

Originally Posted by CornedBee

It's legal, and since enums are often used simply for defining a related group of integer constants (as you are doing), all the suggestions about storing a status_type or that are just overengineering.

You're probably right, but that's no fun. No, actually I was thinking you wanted to compare to all the enums or something, rather than one specific one.