Beginner Error

**strokebow** · 09-18-2008

Code:

#include <iostream>
#include <string>

void main ()
{
	char studentId[7] = "";
	short numOfChars = 0;

	cout << "Enter Student ID: ";
	cin.getline(studentId, 7);

	numOfChars = strlen(studentId);

	if(numOfChars == 6)
		if(stricmp(studentId, "ABC123") == 0)
			cout << "\nAccepted";
		else
			cout << "\n Not Accepted" << endl;
	else
		cout << "The Student ID must be atleast 6 chars" << endl;
	//endif

}

Hi,

I am getting 4 errors with this and I have spent long time but cannot see my errors.

It gives four sayin that the cin and cout are undeclared identifiers?

**robwhit** · 09-18-2008

cin and cout are in the std:: namespace.

http://faq.cprogramming.com/cgi-bin/...&id=1043284376

**te5la** · 09-18-2008

You have not included the standard library

Code:

#include <iostream>
#include <string>

using namespace std;

void main ()
{
	char studentId[7] = "";
	short numOfChars = 0;

	cout << "Enter Student ID: ";
	cin.getline(studentId, 7);

	numOfChars = strlen(studentId);

	if(numOfChars == 6)
		if(stricmp(studentId, "ABC123") == 0)
			cout << "\nAccepted";
		else
			cout << "\n Not Accepted" << endl;
	else
		cout << "The Student ID must be atleast 6 chars" << endl;
	//endif

}

**laserlight** · 09-18-2008

Originally Posted by te5la

You have not included the standard library

That is not accurate since the <iostream> standard header was included, though your fix is one correct solution. robwhit's analysis is accurate, so an alternative fix is to fully qualify the names as std::cin and std::cout.

Also, note that void main() should be int main(), and that stricmp() is not in the standard library. strcmp(), on the other hand, can be found in <cstring> (not <string>).

**Darryl** · 09-19-2008

There is another mistake that was missed. Your nested elses are wrong. Should follow this pattern...
if
else if
else

you can have multiple else if, but only one else.

**laserlight** · 09-19-2008

Originally Posted by Darryl

There is another mistake that was missed. Your nested elses are wrong. Should follow this pattern...

No, that is not a mistake. For one thing, it is a matter of good style rather than something that must be done, but more importantly, the structure of the code is such that that pattern is not applicable. There is simply no if statement nested in an else block.

EDIT:

Originally Posted by Darryl

you can have multiple else if, but only one else.

Look again: the code is well indented, though adding some braces probably would help avoid such a mistake in reading the code.

**CornedBee** · 09-19-2008

Originally Posted by Darryl

There is another mistake that was missed. Your nested elses are wrong. Should follow this pattern...
if
else if
else

you can have multiple else if, but only one else.

The nesting is correct.

Code:

if
  if
  else
else

Braces make this easier to see, though.

Code:

if {
  if {
  } else {
  }
} else {
}

What hasn't been commented on yet is the void main mistake. main returns an int, always.

**laserlight** · 09-19-2008

Originally Posted by CornedBee

What hasn't been commented on yet is the void main mistake. main returns an int, always.

Tsk tsk, read post #4.

**robwhit** · 09-19-2008

Originally Posted by laserlight

Tsk tsk, read post #4.

And post #2.

**CornedBee** · 09-19-2008

OK, I'm blind this evening.

**Daved** · 09-19-2008

If you are a beginner you should be learning C++ strings, not C style character arrays.

Thread: Beginner Error

Thread Tools

Search Thread

Display

Beginner Error

Similar Threads

Getting an error with OpenGL: collect2: ld returned 1 exit status

Making C DLL using MSVC++ 2005

We Got _DEBUG Errors

ras.h errors

Learning OpenGL