Thread: Is there anything illogical here...

Code:

void Rental::ViewContract()
{
	system("cls");

	ContractsIterator iter = find();
	
	/* 
	 * Load contract list with contracts saved in file
	 *
	 */
	
	Contract contract;
	ifstream infile;
	char filename[MAX_PATH] = "contract.txt";
	
	infile.open(filename);
	while ( !contract.Read(infile, false, "0") ) {
		contractList.push_back(contract);	
	}

	/* 
	 * View Contract on screen 
	 *
	 */

	system("cls");
	
	// Headings ....

	printf("\n\n%-18s%-16s%-8s%-12s%-15s\n\n",	"Ref. No", 
		"Rental-Type", "Group", "Car-Reg", "Date-Time of Contract");	

	if(iter != contractList.end() )  //  < -- CXX0039: Error: symbol is ambiguous

	{
              // Displaying the Contract  ... 
	}
	else {
		puts("\n\nNo contracts !");
	}
}

RUN-TIME Error! complains about contractList.end()

Oops! missplaced this ContractsIterator iter = find();, should be after i read from file..

But still, why is it crashing.. Whether or not i've loaded from file, .end() should always exists

Are you using your own Read() member function correctly? Can you please post your whole class.

Wait. Are you getting a compile-time error or a run-time error? (Error: symbol is ambiguous sounds like a compile-time error to me, but what do I know.) How many things do you have called contractList?

Originally Posted by tabstop

Wait. Are you getting a compile-time error or a run-time error? (Error: symbol is ambiguous sounds like a compile-time error to me, but what do I know.) How many things do you have called contractList?

the "Error: symbol is ambiguous" is on the watch window when i debug, i dragged ConractList to the watch window, as i reach the while loop, i get the debug/run-time error .. Well, as i said, after replacing the find() function it now works... But then my thinking you should be able to point to the end of the list whether or not you've loaded stuff to the Vector!! besides, read loads stuff before i call .end() ...

Code:

// Read the contract details from file, or enter new contract
bool Contract::Read(std::istream& indata, bool newContract, std::string refNum)
{
	indata >> *this;	

	// Set rental dates to current date
	if(newContract)	
	{
		contractID=refNum;
		issued.SetDate( issued.getCurrentTime() );
	}
	else
		indata >> issued;

	return indata.fail();
}

// Overload for reading contract details from a filestream
std::istream& operator>>(std::istream& in, Contract& contract)
{
	std::string contractID;
	std::string rentalType;
	std::string carReg;
	char carGrp;

	in >> contractID;
	in >> rentalType;
	in >> carGrp;
	in >> carReg;

	contract.SetContractDetails(carReg, rentalType, carGrp, contractID);

	return in;
}