Thread: Filter directory search results.

I would suggest substr so that you're comparing to the end instead of searching the whole string. If you''re looking for .txt files, foo.txt.bar would match with the current function

ok so i have come up with this...

Code:

int getdir (std::string dir, std::vector<std::string> &files, std::string filetype)
{
    DIR *dp;
    struct dirent *dirp;
    if((dp  = opendir(dir.c_str())) == NULL) {
        std::cout << "Error(" << errno << ") opening " << dir << std::endl;
        return errno;
    }

    while ((dirp = readdir(dp)) != NULL) {
        if (std::string(dirp->d_name).substr((std::string(dirp->d_name).length()-filetype.length()),filetype.length()).find(filetype)!= std::string::npos )
           files.push_back(std::string(dirp->d_name));
    }
    closedir(dp);
    return 0;
}

it compiles fine, but when i try to run it i get this error...

Code:

This application has requested the Runtime to terminate it in an unusual way.
Please contact the application's support team for more information.

Originally Posted by matsp

Wearing the hat of guessing, I would suspect that

Code:

std::string(dirp->d_name).length()-filetype.length())

becomes negative - for example, the filename "." and ".." to be shorter than some filetypes.

As a side note:
std::string(dirp->d_name) is repeated three times in this line:

Code:

if (std::string(dirp->d_name).substr((std::string(dirp->d_name).length()-filetype.length()),filetype.length()).find(filetype)!= std::string::npos )
           files.push_back(std::string(dirp->d_name));

You should probably create a temporary variable.

--
Mats

Ah cheers for that. if I use that function with out the file type filtering the first two results are always “.” and “..”

How could I get past this problem?

Originally Posted by Loic

Ah cheers for that. if I use that function with out the file type filtering the first two results are always “.” and “..”

How could I get past this problem?

Use rfind?

Originally Posted by Loic

Ah cheers for that. if I use that function with out the file type filtering the first two results are always “.” and “..”

How could I get past this problem?

Just put up a check comparing the string to . and .. before doing anything else

Just a recommendation for the boost::filesystem library if you're going to do a lot of this kind of work.

Originally Posted by rags_to_riches

Just a recommendation for the boost::filesystem library if you're going to do a lot of this kind of work.

Cheers that looks good… ill have a read of that, but I still wouldn’t mind trying to get this other function I have to work.