Return *any* container

[39ster]

I was just converting a function from

bool SaveStringList(const std::vector<std::string>& strList, const std::string& fileName)

to

template<class InputIterator>
bool SaveStringList(InputIterator first, InputIterator last, const std::string& fileName)

so it can take any container type. I wanted to do the same with
std::vector<std::string> LoadStringList(const std::string& fileName)

Where it returns any container type. Anyone know a way i can do this?

[laserlight]

Instead of returning a container, take an iterator to the start of a range. Iterator adapters like back_inserter() can then be used to add elements to a container via an iterator to its first element.

[39ster]

Hmmm, i'm new to iterators but i'm assuming that would look like this..?:

std::vector<std::string> strList;
LoadStringList(strList.begin(), "somefile.txt");

Is there anyway i can have it like this:

std::vector<std::string> strList = LoadStringList("somefile.txt");

or

std::vector<std::string> strList = LoadStringList<std::vector>("somefile.txt");

[laserlight]

Hmmm, i'm new to iterators but i'm assuming that would look like this..?

Yes, but if you do not use an iterator adapter, it implies that your container already has as many elements as is needed.

Is there anyway i can have it like this:

Yes, you could do the latter, e.g.,

template<class T>
T LoadStringList(const std::string& fileName)
{
    T container;
    // ...
    return container;
}

You cannot use the former since the template argument cannot be deduced from the function template argument.

[39ster]

Ok thanks i've gone with your way. Is this how it should look?

template <class T>
bool LoadStringList(T& strList, const std::string& fileName)
{
    char line[0xFFFF];
    std::back_insert_iterator<T> it = back_inserter(strList);
    ...
}

std::vector<std::string> strList;
LoadStringList(strList, "somefile.txt");

[39ster]

Hmmm ok i have a new problem. This "back_inserter" method doesn't work on the container std::set. It says there is no member named push_back (which i assume back_insert:perator=() calls).

BTW: Is std::set the correct container to use? The container i need has to store unique strings. I don't want it to add a new string if the string already exists.

[CornedBee]

Ok thanks i've gone with your way. Is this how it should look?

No, the function should take the iterator as an argument, not the container. As you've seen, you otherwise run into problems with std::set.

template <typename Iter>
void LoadStringList(Iter it, const std::string &filename)
{
  // ...
  *it = str;
  ++it;
  // ...
}

void into_vector()
{
  std::vector<std::string> v;
  LoadStringList(std::back_inserter(v), filename);
}

void into_set()
{
  std::set<std::string> s;
  LoadStringList(std::inserter(s), filename);
}

I'm not 100% sure about the name of the insertion iterator that works with std::set.