Thread: Please check my C++

Originally Posted by csonx_p

Well even that, i think i still need the two classes... But as you say, remove the Car & Driver from contract class and replace them with car registration & person's ID No.... But the use the driver class for calling up the lender when needs be....

Looking forward to this!

Yes, you obviously need a driver class, and a contract class - my only objection was the actual content of the contract class.

--
Mats

Code:

// Class CONTRACT: Handles the rental contract details

#include <string>
#include "Date.h"

using namespace std;

class Contract
{
public:
	Contract();
	void setContractDetails(Date i, Date r, unsigned carR, 
		unsigned lndrID, string contID);
	string getContractID();
	Date getIssueDate();
	Date getReturnDate();
	unsigned getLenderID();
	unsigned getCarReg();

private:
	string contractID;
	Date issued, returned;
	unsigned lenderID;
	unsigned carRegistration;
};

Code:

// Class ADDRESS : Handles the physical address of the lender

#include <string>

using namespace std;

class Address						
{
public:
	Address();

	Address(string firstLine, string secondLine, string surbub, 
		string city, short code);
	void setAddress(string firstLine, string secondLine, string surbub, 
		string city, short code);
	string getFirstLine();
	string getSecondLine();
	string getSurbub();
	string getCity();
	short getCode();
private:
	string firstLine;
	string secondLine;
	string surbub;
	string city;
	short code;
};

Code:

// Class DRIVER : Handles the driver's or lender's details

#include <string>
#include "Address.h"

using namespace std;

class Driver						
{
public:
	Driver();

	void SetDriverDetails(string fname, string lname, unsigned IDno, 
		string contact, string license);
	string getFName();
	string getSName();
	Address getAddress();
	string getContact();
	unsigned getIDNo();
	string getLicense();

private:
	string firstName;
	string lastName;
	unsigned idNo;
	string license;
	Address address;
	string contact;
};

Code:

// Class DATE : Handles the fleet return and issue dates

#ifndef DATE
#define DATE 1
#endif

class Date						
{
public:
	Date();
	~Date();
	Date(int d,int m,int y,int h,int mn);
	void setTimeAndDate(int d,int m,int y,int h,int mn);
	int getDay();
	int getMonth();
	int getYear();
	int getHour();
	int getMinute();
private:
	int day;
	int month;
	int year;
	int hour;
	int minute;
};

I think that's about enough classes i need for this program ...

Looks ok, but I would not store the postal code of an address as "short" - it prevents your code from being portable to other countries. In the UK for example, the postal code is X(X)9(9) 9XX, where X is "any letter", and 9 is any digit, the () being optional. So that would require a string. Canada uses a similar patter, but slightly jumbled up.

In Sweden and the US, the postal code is a 5-digit number that may reach 99999 [and in the US, there's a sub-zip code of another 4 digits, so the zip-code for a particular location may be 99999-9999, which means that you probably want a string to store that too].

A second note on address would be that you may want a country code in there too - as in car rental it isn't entirely unusual to rent a car in a different country than the country of residence.

On a more coding side of things:

Code:

	Address(string firstLine, string secondLine, string surbub, 
		string city, short code);
	void setAddress(string firstLine, string secondLine, string surbub, 
		string city, short code);
...
	void SetDriverDetails(string fname, string lname, unsigned IDno, 
		string contact, string license);

All of those strings should be const reference values.

I expect you need to be able to "set" the address of a driver as well?

--
Mats

Originally Posted by csonx_p

Isn't the reason i have setAddress()?

Code:

class Driver						
{
public:
	Driver();

	void SetDriverDetails(string fname, string lname, unsigned IDno, 
		string contact, string license);
	string getFName();
	string getSName();
	Address getAddress();
	string getContact();
	unsigned getIDNo();
	string getLicense();
...

Where is setAddress? I guess you just forgot it, but I didn't know you'd thought of it and forgot it, rather than just missed it out because of a "thinko".

If you declare a variable const without initializing it, how does the compiler allow you to initialize it later, or is this an exception with the setters?

The const reference , in for example the SetDriverDetails parameter list, would just tell the compiler "I just need the string of first name to read from, I'm not changing it, I promise", which means that the compiler doesn't have to COPY the string before passing it to the SetDriverDetails function. It also makes it easier to see that firstname ISN'T being changed by SetDriverDetails when viewing an overview of the code.

--
Mats

Originally Posted by csonx_p

Code:

void Driver::SetAddress(Address add)
{
	address = add;
}

just added....

I suppose that SHOULD be Driver::setAddress, rather than Driver::SetAddress? Just to be consistant.

--
Mats