Thread: Tell me what i did wrong!

You haven't changed the code at all since you posted it? Can you post the simplest inputs you give that will make the error happen every time?

of course i've changed it. The debugger narrowed it down to these two functions when the comp makes a move (as far as i can tell.)

I've changed int theBoard[3][3] to char theBoard[9]

Code:

        if(theBoard[4]=='X'){
            int ranCho;
            do {
                ranCho=((rand() % (9)) + 1);
            } while(theBoard[ranCho-1]=='X' && theBoard[ranCho-1]=='O' && ranCho != 0);
            return ranCho;
        }
        if(theBoard[4]=='O'){
            int ranCho;
            do {
                ranCho=((rand() % (9)) + 1);
            } while(theBoard[ranCho-1]=='X' && theBoard[ranCho-1]=='O' && ranCho != 0);
            return ranCho;
        }

These are at the bottom of the move logic to ad a little randomness if the game isn't about to be won. But it seems to be making illegal moves.

Well i did the code duplication to try and see if i could force the correct outcome, but i can't. So right now i'm piping the computers move choice through the function that checks to see if moves are legal. and that's working.

>> of course i've changed it.
I asked you to post the pertinent code, you said the whole code was posted above. But if the code has changed from what was posted above, then the above code isn't as relevant, right?

It's hard enough to read a bunch of code and figure out your error, but if the code is different than what is posted it makes it almost impossible.

Thank you for posting the updated code for spot 5 (I assume that's what that is), but what about the spot 6 code that fails?

Originally Posted by CornedBee

I quote myself:

The first and the second part, however, are mutually exclusive.

This means that the loop will NEVER repeat, and thus ALWAYS accept the first random value, whether it's valid or not.

But i'm, confused shouldn't it loop until ALL the conditions are met?

It loops while the statement is true. So it loops while theBoard[ranCho-1] is 'X' and it is 'O'. Since it cannot be both, that statement will never be true. Since that statement is never true, the loop will always only run once.

ahh gotcha, duh.