Thread: program crashes on exit

hello i have a problem with my blackjack game it was working befor i added a few new functions that allow a split to happen.

the problem is the only thing ive changed is that it now can check if a split can happen(badly at that) the problem seems to be an access to far into an array error?
heres some code that might be causing the problem

Code:

while((a.stick==false)&&(a.bust==false))
	{
		if ((checksplit(a.myHand))==true)
	{
		cout<<"you can split. would you like to?y/n\n";
		char tempa;
		cin>>tempa;
		if (tempa=='y')
		{ *gamestate=splitstate;
		}
		//system("pause");
	}
		char answer;
		cout<<"would you like to 's'tick or 't'wist\n";
		cin>>answer;
		if (answer=='s')
		{
			a.stick=true;
			answer='o';
		}
		if (answer=='t')
		{
			system("cls");
			a.twist(ndeck.drawCard());
			a.handValue();
			for (int j=0;j<b.cardcount;j++)
			{
				cout<<b.myHand[j].value<<b.myHand[j].suit<<" ";
			}
			cout<<endl;			
			for(int i=0;i<a.cardcount;i++)
			{
			cout<<a.myHand[i].value<<a.myHand[i].suit<<" ";
			}
			cout<<endl;
			if(a.value>21)
			{
				a.bust=true;
			}
			answer='o';
		}
	}
		if((a.stick==true)&&(a.bust==false))
		{
			*gamestate=dealerturn;
			return;
		}
		if (a.bust==true)
		{
			Sleep(1000);
			*gamestate=whowon;
			return;
		}
		

}

thats one function here is the other it could be from

Code:

bool checksplit(card thand[])
{
	for (int i=0;i<5;i++)
	{
		for (int j=0;j<5;j++)
		{
			if (j!=i)
			{
				if ((thand[i].value)==(thand[j].value)&&(thand[i].value)>0)
				{
					return true;
				}
			}
		}
	}
	return false;
}

the array only has 5 in it and cant have any more or less than that

thanks for the help and advice i really appreciate it.
i do plan to use vectors soon but it means more code(i think) and i wanted to get the program running smoothly first so that when i do change it to vector's
(which i have no experience with yet)
it will be easier to learn how to use them as i would know that the code did work
in the first place.
but here is my agenda for this game so far.
1.get it working with all the common blackjack (21) features.
2.convert from a consol app to a windows app using the sdl librarys
3.change the arrays to vectors
4.rename all variables and unjumble the code

i know my varible names are quite descret and dont use a proper naming convention either i was just curious as to how messy my code looks to you guys and how i could clean the layout up?
i mean how do you nest for loops and if statments?

oh that sounds a lot simpler than i imagined but i think i will make a test project just to get used to them. it would make my program have so less functions if i did use vecktors because i could have a vecktor of hands for when i split instead of haveing

Code:

class player{
card myhand[5]; // holds my non split hand
card sparehand[5];  // holds my split hand if i get a chance to split
};

but from what i gather i could use this instead? probly different than it should be declared but to the same end as this

Code:

vector <card> hands;

oh super ill take all your advice into account and see how i do im gonna take a detour(testvector.cpp)
then ill rename all variables to something similar to

Code:

 int nMyInt;
double dMyDouble;

oh and how should i name classes and members that i make?

and untab all the code and use spaces instead
then im gonna recode most of my program keeping the parts which i can but using less functions and more vector's (currently over 25 functions for a simple blackjack game lol)
and now i wonder why i didnt learn to use vectors in the first place i kinda been avoiding them as well as avoiding pointers .
i will search the web now and look into how to use vectors and ill stick it until i understand them alot better

well if im honest i dont tab them over when i type and press enter after some things it just auto tabs it over so i think its been lazyness on my part but if 4 spaces looks neater then ill try to use that because you guys help me so much i dont want to make it a chore to be able to read my code

The function 'push_back()' does not guarantee that all its elements are put close to each other in the memory. With a few ints or doubles it doesn't matter, but consider the following pseudo-code:

Code:

double aDouble;
std::vector<double aVector;
std::vector<std::vector<double> > aTable;
for all i { aVector.push_back( aDouble) };
for all j { aTable.push_back( aVector)};

This is really inefficient for a large spectrum of i,j . Instead, consider the following:

Code:

double aDouble;
std::vector<double aVector( its_size);
std::vector<std::vector<double> > aTable ( its_size);
for all i { aVector.at( i) = aDouble };
for all j { aTable.at( i) = aVector};

Visual Studio and other IDEs auto-indent when typing code

I have never ever seen a more horrible editor than the one in Visual Studio. Try emacs instead....