Thread: merging arrays

Make a new array, or reallocate an array. But since these arrays are static, fixed-size, you can't reallocate them, so a new might be necessary. If you have fixed-width arrays, you can define a new fixed-size array which is the length of the two combined. Otherwise you need to allocate a new array dynamically via malloc/free.

But if you only want to print out the data, you don't really need to merge the arrays at all.

So basically, you don't have to store the merged arrays?

And you want to ignore repeats... why not add the element from A providing if it's not in B to C, and the same for B (providing it's not in A) add it to C. Then order C... And output it.

The max size of C will be, sizeof(A) + sizeof(B).

You messed up those code tags.
They should not be [\code], they should be [/code].

1. Input A (not with your broken code - but with a loop)
2. Input B
3. Allocate C big enough to store members of 2 arays
4. Copy A to C
5. for each member of B that is not found in A - copy to C
6. sort C

for example

Originally Posted by IceDane

1. Input both arrays, A and B,
2. Allocate a new one that's size sizeof(A)+sizeof(B)
3. Put numbers in new array - use a loop.
4. Delete the repeats.
5. Sort it - bubblesort is easy to implement.
   

Now code.

better sort first - then output ignoring duplicates (only works if A and B do not have duplicates from the beginning)

better sort first - then output ignoring duplicates (only works if A and B do not have duplicates from the beginning)

Heheh, acohrockz21, have you heard of merge sort?

By the way, void main() should be int() main(), clrscr() is non-standard and not needed here, and you should indent your code a little better.

Originally Posted by acohrockz21

dude how can i copy and allocate the members of the array to C?

heres my code.. i dont know what to do next..

Code:

#include<stdio.h>

int main()
{ 
  int a[5];
  int b[5];
  int c[10][10];
  int d;

  /*clrscr();*/
  printf("\n\nEnter values of first array:\n");
  for(d=0;d<5;d++)
  {
    scanf("&#37;d",&a[5]);
  }
  printf("\n\nEnter values of second array:\n");
  for(d=0;d<5;d++)
  {
    scanf("%d",&b[5]);
  }

Indent properly and you'll see you're missing an ending }.
And don't use void main. Use int main. And avoid clrscr. It's non-standard.
It also seems to me that you need to go back to the books because this is code that will get you nowhere. It's not even functional right now.

Originally Posted by acohrockz21

sorry T_T likewise i sad im still a newbie in C im still studying

But that's why I told you to consult the books a little more. To try to grasp the more basics concepts before moving on.
Don't worry, everyone starts off as a beginner. You just need practice.
I can highlight the problems in the code if it makes you feel better.

int c[10][10];
The array is a 2D array of 10 x 10 elements, which is too much. You don't need all that space.

Code:

  for(d=0;d<5;d++)
  {
    scanf("%d",&a[5]);
  }

This code loops 5 time and writes the input to the 5th (or rather 6th) element of the array, which btw, does not exist. When you create an array of 5 elements (such as int a[5]), then you get elements 0 to 4 (number of elements - 1, since indexing starts from 0, not 1).
Writing over the same data over and over is not very productive and writing beyond the end of the array is a security risk.

In itself, a, b, c and d are not very good variable names. They tell nothing of what they're used for, so it's better to use productive names that tells what they are used for.
And finally, you need to indent better so you can match all the { and } correctly. If you need help indenting, use a code beautifier or an IDE that indents for you, such as Visual Studio (Express).

Welcome to C.
Good luck.