Thread: Help with Diaming program

The object is to make a program that does what this attatched program does.

change the file to .exe and it will run the program.

I need help with this.

Its supposed to make a diamond shape with the inputted number.

If you put in 3 it should do this

*
**
***
****
*****
****
***
**
*

but in the shape of a diamond

Ill post the code later.

this is what I have so far.

The j is my friends, what can I do to make his program more efficient?

If you have some code, then post it up, highlight it, and click on the pound symbol # to wrap it in code tags.

Don't post links to docs, etc. That's a waste of time.

Code:

#include<stdio.h> 
#include<conio.h> 
intmain( void ) 
{
int n = 0; //number of lines 
int countUp = 0; //counts number of lines 
int totalCount = 0; //counter that stores other counts 
int tempCount = 0; //Counter used randomley 
int spaceCount = 0; //space counter 
int tempSpace = 0; 
int a; //counts asterisks 
while
(1 > 0){ 
printf("Enter a number or 0 to exit:"); 
scanf("&#37;d", &n); 
if(n !=0) //decides placement of first asterisk {
for(countUp = 1; countUp < n; countUp++) 
printf(" "); 
printf("*"); 
for(a = n; a > 1; a--) 
printf(" "); 
printf("\n"); 
while(n > 1) //determines upper half of diamond 
{
n--;
totalCount = totalCount + 2;
for(countUp = 1; countUp < n; countUp++) 
{
printf(" "); 
}
tempCount = totalCount + 1;
while(tempCount != 0) 
{
printf("*"); 
tempCount--;
}
for(a = n; a > 1; a--) 
{
printf(
" "); 
}
printf(
"\n"); 
}
while
(totalCount > 2) //determines lower half of diamond 
{
spaceCount++;
tempSpace = spaceCount;
while(tempSpace > 0) 
{
tempSpace--;
printf(
" "); 
}
totalCount = totalCount - 2;
tempSpace = totalCount;
while(tempSpace >= 0) 
{
printf(
"*"); 
tempSpace --;
}
tempSpace = spaceCount;
while(tempSpace > 0) 
{
printf(
" "); 
tempSpace--;
}
printf(
"\n"); 
} 
if
(totalCount != 0) 
{
tempSpace = spaceCount;
while(tempSpace >= 0) 
{
printf(
" "); 
tempSpace--;
} 
printf(
"*"); 
tempSpace = spaceCount;
while(tempSpace >= 0) 
{
printf(
" "); 
tempSpace--;
}
printf(
"\n"); 
}
 
}
//sets all variables back to defaults 
n = 0; 
countUp = 0; 
totalCount = 0; 
tempCount = 0; 
spaceCount = 0; 
tempSpace = 0;
a = 0; 
}
getche();
return
0; 
}

what can I do to make this more efficient?

Code:

#include<stdio.h>
#include<conio.h>
int main(void)
{
    int n = 0;			
    int countUp = 0;		
    int totalCount = 0;		
    int tempCount = 0;		
    int spaceCount = 0;		
    int tempSpace = 0;
    int a;	
    while (1 > 0) {
	printf("Enter a number or 0 to exit:");
	scanf("%d", &n);
	if (n != 0)		 {
	    for (countUp = 1; countUp < n; countUp++)
		printf(" ");
	printf("*");
	for (a = n; a > 1; a--)
	    printf(" ");
	printf("\n");
	while (n > 1)		{
	    n--;
	    totalCount = totalCount + 2;
	    for (countUp = 1; countUp < n; countUp++) {
		printf(" ");
	    }
	    tempCount = totalCount + 1;
	    while (tempCount != 0) {
		printf("*");
		tempCount--;
	    }
	    for (a = n; a > 1; a--) {
		printf(" ");
	    }
	    printf("\n");
	}
	while (totalCount > 2)	
	{
	    spaceCount++;
	    tempSpace = spaceCount;
	    while (tempSpace > 0) {
		tempSpace--;
		printf(" ");
	    }
	    totalCount = totalCount - 2;
	    tempSpace = totalCount;
	    while (tempSpace >= 0) {
		printf("*");
		tempSpace--;
	    }
	    tempSpace = spaceCount;
	    while (tempSpace > 0) {
		printf(" ");
		tempSpace--;
	    }
	    printf("\n");
	}
	if (totalCount != 0) {
	    tempSpace = spaceCount;
	    while (tempSpace >= 0) {
		printf(" ");
		tempSpace--;
	    }
	    printf("*");
	    tempSpace = spaceCount;
	    while (tempSpace >= 0) {
		printf(" ");
		tempSpace--;
	    }
	    printf("\n");
	}

	{

    n = 0;
    countUp = 0;
    totalCount = 0;
    tempCount = 0;
    spaceCount = 0;
    tempSpace = 0;
	a = 0;{

_getche();
return 0;
}

Alright so this is what I have...it works but only works the first time.

Like when I put in a number it does what its supposed to but when it loops back and I enter another number its messed up...it spaces the bottom out farther and farthe with each number.

Also, it doesnt end when I put in 0.....

what should I do so it doesnt get messed up after each one and how do I make it end when i put in 0?

Originally Posted by swgh

After you read in the number, explicitly tell the program to exit if the command is zero

Code:

 if ( input == 0 )
{
   abort();
}

Im using c

It says theres no such thing as abort

Code:

#include<stdio.h>
#include<conio.h>
int main(void)
{
    int n = 0;			
    int u = 0;		
    int t = 0;		
    int c = 0;		
    int s = 0;		
    int p = 0;
    int a;	
    while (1 > 0) {
	printf("Enter a number or 0 to exit:");
	scanf("%d", &n);
	if (n != 0);		 {
	    for (u = 1; u < n; u++)
		printf(" ");
	printf("*");
	for (a = n; a > 1; a--)
	    printf(" ");
	printf("\n");
	while (n > 1)		{
	    n--;
	    t = t + 2;
	    for (u = 1; u < n; u++) {
		printf(" ");
	    }
	    c = t + 1;
	    while (c != 0) {
		printf("*");
		c--;
	    }
	    for (a = n; a > 1; a--) {
		printf(" ");
	    }
	    printf("\n");
	}
	while (t > 2)	
	{
	    s++;
	    p = s;
	    while (p > 0) {
		p--;
		printf(" ");
	    }
	    t = t - 2;
	    p= t;
	    while (p >= 0) {
		printf("*");
		p--;
	    }
	    p = s;
	    while (p > 0) {
		printf(" ");
		p--;
	    }
	    printf("\n");
	}
	if (t != 0) {
	    p = s;
	    while (p >= 0) {
		printf(" ");
		p--;
	    }
	    printf("*");
	    p = s;
	    while (p >= 0) {
		printf(" ");
		p--;
	    }
	    printf("\n");
	
	}
	}
	
    n = 0;
    u = 0;
    t = 0;
    c = 0;
    s = 0;
    p = 0;
	a = 0;
	}
	_getche();
return 0;
}

Alright, thats what I have...it works perfectly except it doesnt exit when I put in 0...it just does nothing then asks the same thing again...enter the number or press 0 to exit

So, your loop only stops when 1 <= 0. If that's not when you want your loop to stop, then maybe you should change that.