Thread: Porblem In Coding !!!!

Originally Posted by edesign

no you cant do it like that..
when you write char a or int b
you are defining a variable,which is of datatype char or int respectively...you need to follow some rules to give a variable name...you can't have a variable named a-b, or 'a'..why you wanted to use char 'a'?

also your logic is wrong..
for ascii values between 97 to 122 we have small letters...
Ask if still in doubt

i have checked my above mentioned pgm , their i mentioned 97 to 122 is for small case letter??? you can see that????

but agian the problem remains there..... what will be the soluiton of the error i m getting...check the pgm code once agin.

Originally Posted by vart

Look at this sample

Code:

if((a>='0' && a<= '9'))
   printf(" Digit");

Isn't it more readable?
Make the rest of your checks the same way

Yor are correct man...... and also i started to experiecnce the real meaning of "Readable" word... i have heard it 100 times.. but never experience it..

Thanks alot

Now after this much i started to get output but still there are few problems... i m getting the digit working but when i put small case letter it says " CapsLock " and when input a symbol like " @ , ) .> somthing like this ..it says small case letter.????????????????

what may be the troubale...i check the ascii code and code written by me also... i feel everything is correct .??? can some one check my code and suggest something.l

Code:

if((a>=65 && a<=90)||(a>=97 && a<=122))
	{
		printf("CapsLock"); /* In this Line i get Error "Expression syntax is in function main() */
	}

you are printing caps for both the cases...understand the meaning of logical or??
Also, it will be better if you use nested if..else as i suggested earlier
use char constants such as a>='A'
or use like: if((int)a>=97...)

read earlier posts,if you can...try to correct errors suggested...

Originally Posted by edesign

Code:

if((a>=65 && a<=90)||(a>=97 && a<=122))
	{
		printf("CapsLock"); /* In this Line i get Error "Expression syntax is in function main() */
	}

you are printing caps for both the cases...understand the meaning of logical or??
Also, it will be better if you use nested if..else as i suggested earlier
use char constants such as a>='A'
or use like: if((int)a>=97...)

I also feel that i if i use nested if-else then i can do it easily but i bound to use logical operators as i m learning it now. ofocurse if -else will make it more easier but the code will look damn congested......

so i have to use logical oeprators and i feel there is something i missing in my logic....

i just divided this part in two parts and remove the else and braces.... and i started to get out put correctly for small cases.. and again i added OR operator in the logic line for Specail Symbol and i got the out put correct but still i m getting one " Warning While Compiling " i.e Constant out of range in camparison in funciton main() since it is just a warning even then my pgm worked.But if someone knows that why m i getitng this warning please educated me about that.. i m posting the code for that....

Code:

#include <stdlib.h>
#include <conio.h>
#include <ctype.h>
#include <stdio.h>
main()
{
char a;
printf(" Enter Any Char in Capital or small case or any digit or any number");
scanf("&#37;c",&a);
clrscr();

if((a>=65 && a<=90))

printf("CapsLock"); 
if((a>=97 && a<=122))
printf("Small Case letter");
 
 
 if((a>='0' && a<='9'))
 printf(" Digit");
 
 
if((a>=0 && a<=46)||( a>=58 && a<=64)||( a>=91 && a<=96)||( a>=123 && a<=127))    /* In this line i get warning that " Constant out of range." */

printf("Speical Symbol");

getch();


}

Any suggesting for improvement on basic level for me.that will be very kind of u.and any comment over the warning i m getting in the above mention pgm.?

Originally Posted by Elysia

Get a better compiler, like Visual Studio.
Indent properly.
Use getchar() instead of getch().
Use int main, not main.
Don't use a >= some_number, do a >= 'my char' instead.

Very Nice advices ! this will really help me to write my pgm better ...

Code:

Don't use a >= some_number, do a >= 'my char' instead.

I just did not understand this thing.....
and which version of visual studio is easy to use and good.and does we need to study somthing else to operate visual stdio?

shd i go for visual stdio 5 express or 2008?
i have alredy Microsoft Visual 6 c++ ?

Pleae guide.

The program seems to be correct even though a bit ugly.
It surprised me the fact that people still use tools like TurboC.
Well, here goes a small remark on the warning you get.

[CODE]if((a>=0 && a<=46)||( a>=58 && a<=64)||( a>=91 && a<=96)||( a>=123 && a<=127))/CODE]

The last comparison of a<=127 gives you the warning.
If you read a little about the "C" built-in data types you will learn that there are some things
which are called specifiers. The most commonly used is 'unsigned', but it's brother 'signed' also exists because some people like to say exactly what a variable is. For "C" the default specifier on any integral( char, short, int, long ) type is 'signed'. Yup that's what you get when you write:

Code:

char a;
signed char a;  /* The two declarations are equal */

'a' has sign. And because it is of type 'char' it is 1 byte big.
Because 'a' is 1 byte big, there are 256 different values it can take.
Because 'a' has sign, the range of values it can take was decided to be from -128..127.
Therefore the compiler knows that 'a' is always less or equal to 127, thus warning you
about a possible error in your programs logic, which is a comparison that always holds true.