Unlimited Inputs and Determines which is greatest and lowest

**matsp** · 02-07-2008

Post #7 has a solution, and if you combine that with post #8, you would have a "simpler" solution.

--
Mats

**omarbags** · 02-07-2008

Code:

int w,x,y,ans;
printf("Enter a number: ");
scanf("%d",&x);
do{
for(y=1;y<=x;y++){
printf("Input number: ");
scanf("%d",&w);
if(w>y)
ans=w;
	}
		}
while(y<=x);
printf("The highest number is %d.\n",ans);

just a little bit more T_T

help please

**abachler** · 02-07-2008

Code:

 
BOOL isFirst;
DWORD Biggest;
DWORD Smallest;
 
// get number of values N
 
isFirst = TRUE;
for(i=0;i<N;i++){
    //get the input value V
    if(isFirst){
        Biggest = V;
        Smallest = V;
        isFirst = FALSE;
        } else {
        Biggest = __max(V , Biggest);
        Smallest = __min(V , Smallest);
        }
    }
 
// print out the biggest and smallest value

**omarbags** · 02-07-2008

waaaaaaaaaaaaaaaaaa

i cant understand T_T

**Elysia** · 02-07-2008

Originally Posted by abachler

Code:

 
BOOL isFirst;
DWORD Biggest;
DWORD Smallest;
 
// get number of values N
 
isFirst = TRUE;
for(i=0;i<N;i++){
    //get the input value V
    if(isFirst){
        Biggest = V;
        Smallest = V;
        isFirst = FALSE;
    } else {
        Biggest = __max(V , Biggest);
        Smallest = __min(V , Smallest);
    }
}
 
// print out the biggest and smallest value

Code:

if (x) {
    }

Is never a good coding style...

omarbags:
If you can't understand such simple code, then programming may not be for you.

**laserlight** · 02-07-2008

i cant understand T_T

What part do you have trouble understanding?

Is never a good coding style...

In this case isFirst is clearly a boolean variable, and the variable is named isFirst, not something with so little context as x.

If you can't understand such simple code, then programming may not be for you.

To be fair, abachler's code example uses type and function names found in a library that is not part of standard C.

**Elysia** · 02-07-2008

Originally Posted by laserlight

In this case isFirst is clearly a boolean variable, and the variable is named isFirst, not something with so little context as x.

I was on about bracket placement...

To be fair, abachler's code example uses type and function names found in a library that is not part of standard C.

Perhaps. Perhaps not. Let's reserve judgment, then, until later.

**abachler** · 02-08-2008

Originally Posted by Elysia

Code:

if (x) {
    }

Is never a good coding style...

(snipped for social acceptability of the post) I use K&R style and if you dont like it take it up with them.

here, prepend this then and it will work fine

Code:

#define BOOL int
#define DWORD unsigned int

that is after all, exactly what VC++ does.

**Elysia** · 02-08-2008

Originally Posted by abachler

(snipped for social acceptability of the post) I use K&R style and if you dont like it take it up with them.

No,

Code:

if (x) {
}

Is fine. K&R style.

Code:

if (x) {
	}

Is not fine. Not K&R style.

**robatino** · 02-08-2008

It could be some kind of hybrid K&R and Allman, I suppose. An indenting style doesn't necessarily have to be one of the standard ones (I use a modified K&R where I indent functions the same as everything else).

Edit: Sorry, substitute Whitesmiths for Allman.

**Elysia** · 02-08-2008

Yes, coding styles are something that you should make up yourself. However, there are still guidelines to follow or you'll make it confusing.
The least confusing style IMO is Allman. Then K&R, then the rest.
Nevertheless, that hybrid style is not a good one. Brackets should be at the same level, otherwise it's confusing to the reader.

**omarbags** · 02-09-2008

is the program working?

i hope someone could give me a simplified program

im really slow in C programming and i am learning it here...

thanks a lot to everyone who could help me

**laserlight** · 02-09-2008

You have not answered my question yet, namely, what part do you have trouble understanding?

**omarbags** · 02-09-2008

in here T_T

Code:

if(isFirst){
        Biggest = V;
        Smallest = V;
        isFirst = FALSE;
    } else {
        Biggest = __max(V , Biggest);
        Smallest = __min(V , Smallest);
    }
}

**Elysia** · 02-09-2008

You don't understand any of the code, or just some specific part such as V or __max or __min?

Thread: Unlimited Inputs and Determines which is greatest and lowest

Thread Tools

Search Thread

Display