Thread: if else loop

Code:

printf("Enter the employee's id number: ");
	scanf("%d", &temp_id);
	for(index = ZEROI; index < MAX_EMPLOYEE; index++)
	{
		if(temp_id == id[index])
		{
			for(loop = ZEROI; loop <= COLUMN; loop++)
			{
				class[index][loop] = NULL;
				firstName[index][loop] = NULL;
				lastName[index][loop] = NULL;
				salary[index] = ZEROI;
				id[index] = ZEROI;
			}
		}
		else
		{
		printf("No employee with this id currently works here\n");
		}
	}

This is part of a function that is supposed to check if the entered id exists, if it does then zero out all of values. If the id does not exist then print that no employees work there... Problem is, is that while it does zero out the values it is still printing out that no employees with that id works there. I cant figure out why it is still running the else statement if the if is executed.

Looks like you need a break statment

Code:

printf("Enter the employee's id number: ");
	scanf("%d", &temp_id);
	for(index = ZEROI; index < MAX_EMPLOYEE; index++)
	{
		if(temp_id == id[index])
		{
			for(loop = ZEROI; loop <= COLUMN; loop++)
			{
				class[index][loop] = NULL;
				firstName[index][loop] = NULL;
				lastName[index][loop] = NULL;
				salary[index] = ZEROI;
				id[index] = ZEROI;
			}
                    break;
		}
		else
		{
		printf("No employee with this id currently works here\n");
		}
	}

SSHarish

well the break; worked, but I don't see why its not just skipping of the else if the if() is executed.

Can you show us how have u declared your varibled. You dont have to insert null on every element of your array. It not a 2D array. Or i could say that u dont want a 2D array to just store a one name. You might be looking for something like this

Code:

firstName[0] = '\0';

And perhaps that applies for other variables as well.

ssharish

so firstName[0] = '\0'; will null out all of the columns in the first row?

Originally Posted by Fox101

so firstName[0] = '\0'; will null out all of the columns in the first row?

OK from what i understand is that u have a 2D array. Ok if that was the case yes it null out the first[index][loop].

ssharish

My other problem was that the else was inside the for loop, so while it searched to see if the id was valid it printed the statement every time it was not. I fixed that issue.

Code:

{
	int index;
	int loop;
	int temp_id;
	int valid_id = FALSE;
	
	printf("Enter the employee's id number: ");
	scanf("%d", &temp_id);
	for(index = ZEROI; index < MAX_EMPLOYEE; index++)
	{
		if(temp_id == id[index])
		{
			valid_id = TRUE;
			break;
		}
	}
	
	if(valid_id == TRUE)
	{
		for(loop = ZEROI; loop <= COLUMN; loop++)
		{
		class[index][loop] = NULL;
		firstName[index][loop] = NULL;
		lastName[index][loop] = NULL;
		}
		salary[index] = ZEROI;
		id[index] = ZEROI;
		*numEmploy -= DECREMENT;
		
	}
	else
	{
	printf("No employee with this id currently works here\n");
	}
	
	
}

	
}

Well, i fixed some issues, but now it zeros out the id i input but it also NULLs the names and class of the array above the one that it is supposed to. Ive tried everything I can think of.

I get the warning that assignment makes integer from pointer without a cast. its on all 3 lines where it should be nulling out the strings. What does this warning mean?