Thread: strings Vs. Char pointers

Originally Posted by aijazbaig1

Hello,
heres the code:

Code:

...
void set2caps(char *str_hld)

{
    unsigned int chr_cnt = 0;
    char temp;

    while(str_hld[chr_cnt]) {
        if (!isupper(str_hld[chr_cnt]))
            temp = toupper(str_hld[chr_cnt]);
        str_hld[chr_cnt] = temp;
        chr_cnt++;
    }
}

Actually, there's a bug in this function. It should be changed as follows:

Code:

void set2caps(char *str_hld)
{
    unsigned int chr_cnt = 0;
    char temp;

    while(str_hld[chr_cnt]) 
    {
        if (!isupper(str_hld[chr_cnt]))
        {
            temp = toupper(str_hld[chr_cnt]);
            str_hld[chr_cnt] = temp;
         }
         chr_cnt++;
    }
}

Otherwise, all letters that were previously capitalized are either ignored (temp is not initialized) or set to the previous uncapitalized letter.

Originally Posted by Elysia

I can't be bothered with C++ casts. IMHO, they're too long to type.

I ONLY use C++ casts (in C++ at least).
C++ casts allow the compiler to tell you if you're doing something wrong (like removing const when all you wanted to do is cast the type).
They also allow you to easily search & find any casts in your code, so you can remove them later if you change your code to make them unnecessary. Try searching for a C cast -- not quite as easy, especially if different coding styles are used.
They make the intent of your cast obvious to everyone that reads it because each C++ cast does only one job. With C casts, people don't know if you actually intended to remove const or if it's a bug...