Thread: Creating Log File

Hello,

I'm trying to write a function that will create a log file. I have code in here to get the current system time and day and doing a strcat to add it to the file name. However, when I run it, it doesnt create the file. When I do a printf, I can see the file name. But it never creates the file. I appreciate any help.

Code:

void BuildLogFile(char *drive)
{
// Build path to log
	
	char logFileName[100] ="";
	char s[30];
	size_t i;
	struct tm tim;
	time_t now;
	
	now = time(NULL);
	tim = *(localtime(&now));
	i = strftime(s,30,"%m%d%I%M\n",&tim);

	strcpy(logFileName, drive);
 	strcat(logFileName, ":\\Test\\GrpClean_");
	strcat(logFileName, s);
	strcat(logFileName, ".log");
	
	fpLogFile = fopen(logFileName,"w");

}

I'm trying to write a function to create a log file that includes the current system time in the file name. When I run this code, I have an error code of "invalid argument" for fopen. When I try to print the file name, its shows up correctly. Also, when I try to replace the system time with "123" the file creates fine. I appreciate any help.

Code:

void BuildLogFile(char *drive)
{
// Build path to log
	
	char logFileName[100] ="";
	char s[30];
	size_t i;
	struct tm tim;
	time_t now;
	
	now = time(NULL);
	tim = *(localtime(&now));
	i = strftime(s,30,"%m%d%I%M\n",&tim);

	printf("%s", s);
	strcpy(logFileName, drive);
 	strcat(logFileName, ":\\Test\\GrpClean_");
	strcat(logFileName, s);
	strcat(logFileName, ".log");
	
	printf("%s",logFileName);
	fpLogFile = fopen(logFileName,"w");

	if (fpLogFile == NULL) 
	{
    perror("Unable to open file");
	}


}

You asked this already, and several people have offered suggestions and questions that you have not responded to as of yet.

http://cboard.cprogramming.com/showthread.php?t=98467

Code:

fpLogFile = fopen(logFileName,"w");

Have you declared fpLogFile globally? If not, you need to declare it somewhere.

Originally Posted by laserlight

Threads merged. Thanks, matsp.

You're welcome Salem.

I thought laserlight was thanking you (matsp) for my suggestion. http://cboard.cprogramming.com/showp...18&postcount=6

Originally Posted by matsp

Yes, I think Laserlight did, but you said thanks to Salem!

--
Mats

Purposefully!