Initialising

What size is "TableSize", and how is the actual "Table T" declared - is it a local variable in a function or as a global variable? If it's a local variable then I'm not at all surprised you run out of stack [well, depending on TableSize and the compiler you are using will influence things too].

--
Mats

IMDB size is #define IMDBSIZE 119467

I'm not sure how large to set table size which could be causing an issue? Its defined in the header file right now.

As with table t

Code:

---

typedef struct
{
  KeyType  Key;
  InfoType Info;
} TableEntry;

typedef TableEntry Table[TableSize];

extern void    Initialize(Table T);

---

Then in the function I call the table in I define

Table T;

and then after all declarations I call


Initialize(T);

That is indeed quite large - 120000 * (200 + 12) -> 25,440,000 - this is definitely too much to use as a local variable on the stack-

The following piece of code works just fine, using MingW gcc 3.4.5.

Code:

---

#include <stdio.h>
#include <stdlib.h>
#include <string.h>

#define TableSize 119467

typedef char KeyType[200];

typedef struct
{
        int  NumberFilms;
        char* Actor;
        char** Films;
} InfoType;

typedef struct
{
  KeyType  Key;
  InfoType Info;
} TableEntry;

typedef TableEntry Table[TableSize];

void Initialize(Table T)
{
 
  // Declare variables
  int i,j;
 
  printf("T = %p\n", T);
 
  //Allocate memory for all pointers in the structure
  for (i=0;i<TableSize;i++)
    {
      T[i].Info.Actor = calloc(1, 200);
      T[i].Info.Films = calloc(50, sizeof(char *));
      strcpy(T[i].Key,"XXX");
      T[i].Info.NumberFilms=0;
      strcpy(T[i].Info.Actor,"nnn");
      for (j=0;j<50;j++)
        {
          T[i].Info.Films[j] = calloc(1, 200);
          strcpy(T[i].Info.Films[j],"hhh");
        }
    }
}

Table T;

int main()
{
  printf("T = %p\n", &T);
  printf("sizeof(T) = %lu\n", (unsigned long)sizeof(T));
  Initialize(T);
  return 0;
}

---

Well that seems to have stopped the error on startup. When it returns the size of T, should I use that value as the table size in #define? THanks for all your help so far. Very thankful!!

Quote:

---

Originally Posted by eeeeej

Well that seems to have stopped the error on startup. When it returns the size of T, should I use that value as the table size in #define? THanks for all your help so far. Very thankful!!

---

No, the sizeof() output is just part of my "understanding how big this thing is".

--
Mats

OK I think it is initializing now. Hoewever if I try to do this.

Code:

---

                               
                        for (i=0;i<IMDBSIZE;i++)
                        {
                                I.Actor = (char *) calloc(strlen(IMDB[i].actor),sizeof(char));

                                strcpy(I.Actor, IMDB[i].actor);

// Getting rid of the first name to store key

                                I.Actor[strlen(I.Actor)-1] = '\0';       
 
// The last name is at the begning of the line
                                lastname_pointer = I.Actor;   

// Search for the comma in the name
                                firstname_pointer = my_strchr(I.Actor, ',');
 
// If there is no slash, set the key to the whole entry
                                if (firstname_pointer == NULL)
                                {

                                        strcpy(K, I.Actor);
                                }
                                else
 
// Move the pointer to the comma in the name
                        *firstname_pointer = NULL;
 
// Move it on by one so it now points to the first name
                        ++firstname_pointer;       
// Now make the name a single entry for the key

                        strcat(firstname_pointer, lastname_pointer);

                                strcpy(K, firstname_pointer);
                                strcpy(I.Actor, IMDB[i].actor);

                                printf("%s\n", K);
                                printf("%s\n", I.Actor);

                                I.NumberFilms=IMDB[i].num_films;

                                I.Films = (char **) calloc(strlen(IMDB[i].films[j]),sizeof(char*));
                                for (j=0;j<IMDB[i].num_films;j++)
                                {
                                        I.Films[j] = (char *) calloc(strlen(IMDB[i].films[j]),sizeof(char));
                                        strcpy(I.Films[j], IMDB[i].films[j]);
                                }
                                        getch();
                        }
                                       
                }
        }

---

it prints out 2 entries and then stops, if I try to insert to a hash table it errors straight away. ANy ideas?

it is getting stuck when there is an entry with no comma in their name like NSYNC

Do you realize that your code is doing the following

Code:

---

if (firstname_pointer == NULL)
{
  strcpy(K, I.Actor);
}
else
{
  *firstname_pointer = NULL;
}
++firstname_pointer;       
strcat(firstname_pointer, lastname_pointer);

---

So when firstname_pointer is null last line tries to add to the pointer that is 0x01 and should crash.

Im not sure how to deal with entries that dont have commas in their name? ANy ideas?
if (strcspn(",", I.Actor)==0);
do this

else store the whole name?

you do not need the ; at the end of if
you need to work on your indentetion
you better use

Code:

---

{}

---

always in if/else blocks