execution crash

[toxicherry]

I am working on counting the no. of words from a input file.
i think the code is alright, however when i click on run,,,
it shows the below photo,,,
what should i do?

my code:

#include <stdio.h>
main()
{
 	  int i, cnt=0;
 	  char ch;
 	  FILE *fp;
 	  fp=fopen("InFile.txt","r");
 	  ch=fgetc(fp);
 	  while (ch!=EOF){
	  		if(ch==' ')
	  		cnt++;
			}
			printf("No of words = %d\n", ++cnt);
			fclose(fp);
			}

[MacGyver]

• Learn how to indent properly.
• Change ch to be an int instead of a char. getchar() returns an int, and you need to use this for certain kinds of input.
• Check if fp is NULL after calling fopen(). This type of scenario could cause your crash.
• Change your loop logic to actually read more than one char. You'll be looping with the same char over and over again.
• If you're really concerned about the exact number of words, per se, then you have to come up with a better algorithm.... ie. reading "Hi there.\nTesting... testing...." will produce only 3 words I believe according to your current algorithm. Depends upon what type of file you're expecting, and how complicated you want to make this.

[ElemenT.usha]

you are reading a character only once... after that no effect on ch
so loop while runs infinitely........

your corrected code would be:

#include <stdio.h>
main()
{
 	  int i, cnt=0;char ch;
 	  FILE *fp;
 	  fp=fopen("InFile.txt","r");
 	  while (  (ch=fgetc(fp)  ) !=  EOF  )
                {
	  		if(ch==' ' || ch=='\n' || ch=='\t')
	  		cnt++;
		}
	   printf("No of words = &#37;d\n", ++cnt);
	   fclose(fp);
}

[vart]

it should be int main
and need to check the return value of fopen before using it
and - for empty file you still report 1 word found