Thread: wrong code to print a string?

Please tell me whats wrong with the code below??

Code:

char buff[100];
FILE* ptr;

while(!feof(ptr)){

 fgets(buff, 100, ptr);
 puts(buff);
}

You're passing ptr to feof() without being initialized.
If you would have turned on all your compiler warnings and it would have told you the same thing.

The first mistake which you have here is using feof function and i cant really see anywhere that you are trying to read something from a file. If you are trying to read from a file you need to open a file first

Code:

FILE *ptr;

if( ( ptr = fopen( <filename>, <mode> ) ) == NULL )
{
     printf("Error: File cannot be opened\n");
     return 1;
}

and then read the file

Read this on why feof shouldn't be used FEOF

ssharish

I am so sorry for this putting this question so vaguely and in a dumb manner: Let me say this again:

I have the following code:

Code:

int main(void) {
FILE *ptr;
char buff[100];
ptr = fopen("file", "r");

while(!feof(ptr)){
 fgets(buff, 100, ptr);
 puts(buff);
}

return 0;
}

I get:

Code:

ELF


ibc_start_main

ÿÿÿ%
=Y
ÉEEøÿHì0ÇEÐ
ÏH     XÿHëÿTÝ
[ÉÃHèýÿÿHÃ

This is total garbage....

Thanks Mat.... now another question...

what would you say about a stupid mistake like the one i made above??!!!

And..... how do you know i am using bubblesort. i haven't mentioned the filename here... have i??

And..... how do you know i am using bubblesort. i haven't mentioned the filename here... have i??

Well just few min before, i saw that you had bubblesort in your filename field in your fopen function. And now you have changed it to "file".

what would you say about a stupid mistake like the one i made above??!!!

What to say, you made a mistake rectify it! A perhaps check the return value of fopen function. Look at my previous post.

ssharish