Reading information from a file

[stewie1986]

Hi,
Just wanted to know if anybody could help me, ive found a test program to see if
I could read information from a text file, and print the information to the screen, prob is when I run the program, visual studio crashes.

#include<stdlib.h>
#include<stdio.h>

int main(void)
{
	FILE *file_in;
	int points;
	char team[20];

	file_in=fopen("Prem.txt", "r");

	while (!feof(file_in))
	{
		fscanf(file_in, "%s, %d", team, &points);
	}

	fclose(file_in);

	printf("Team: %s", team);
}

I think it may have a problem finding the text file on my computer

[MacGyver]

Check if file_in is equal to NULL before you use it.

Don't use feof() to control a loop in this manner... http://faq.cprogramming.com/cgi-bin/...&id=1043284351

[Elysia]

fscanf is clearly bad. My signature contains more information.

[stewie1986]

thanks for the replies, but I just wanted to know if the

file_in=fopen("Prem.txt", "r");

is correct,

just say the file I want to read in is in the C:\ directory, how would I tell the program to look in that directory inorder to find the file?.

[Elysia]

file_in=fopen("C:\\Prem.txt", "r");

[stewie1986]

Hi
I added the code to my test program, but it doesnt seem to print the value of sum. I was hoping it would read the string in the txt file, which was just "PBC", then make the conversion into numbers, then print the value to the screen.

But when I build it, it has no errors, but when I try to run it it just prints out

Answer = <null>

#include<stdio.h>
#include<string.h>

int main(void)

{

   FILE *file_in;
   char letter[20];
   int counter;
   int sum;
   int length;

   if ((file_in = fopen("C:\\Users\\Gopi\\Documents\\roman.txt", "r")) == NULL)
  {
    perror ("C:\\Users\\Gopi\\Documents\\roman.txt");
    
  }

   sum = 0;

   length = strlen(letter);
   strupr(letter);
   
   

   for ( counter = 0; counter < length; counter++ )
 { 
   if ( letter[counter] == 'P' )
   {
	  sum = sum + 1; 
   }
   else if ( letter[counter] == 'B' )
   {
	  sum = sum + 5; 
   }
   else if ( letter[counter] == 'C' )
   {
	  sum = sum + 10; 
   }

   

  }

while (!feof(file_in))
  {
    fgets(letter, sizeof(letter), file_in);
    printf ("Answer = %s",sum);
    
  }
  
  fclose(file_in);
    
  return(0);
}

[Elysia]

You messed up your application structure! You try to process data before reading anything from the file! Re-think your design!

[MacGyver]

It amazes me how people will put code together with no logic. Look at what you're doing. You have code which analyzes the length of a string before you even set it to anything. Then you try to analyze the contents of the buffer before you even read from it. Lastly, you try to read from the file....

To top it all off you incorrectly use feof() as a string, and then when you try to print the answer you format sum, which is an integer, to be printed as a string.

It's no wonder none of this works. You have to do everything explicitly and logically.

Do it closer to this order:

1. Open file.
2. Read from the file.
3. Analyze length of buffer and buffer contents.
4. Print out final result in the right format.