malloc() - arrays

[RyanLeonard]

Hi,
I've been working on a program that asks the user to define the size of the array they would like to make and then input the elements, but skips the input of the elements. What am I overlooking here. My loop seems just fine. It's my first time using the function memory allocation, malloc(); something wrong there?

#include<stdio.h>
#include<stdlib.h>

	long int size;
	long int buffer;
	long int *pNumber = (long int *) malloc(size*sizeof(long int));

int getSize()
{
	printf("How many elements are in the array? ");
	scanf("%l", &size);
	return (size);
}
	
int getElements()
{
	printf("Please enter the elements of the array: \n");
	for(int i = 0; i < size; i++)
	{
		scanf("%l", *(pNumber));
	}
	return(*pNumber);
}

int main()
{
	getSize();
	getElements();
}

[laserlight]

Do not use global variables. When you change to use local variables, you probably would also spot your mistake.

[RyanLeonard]

I have since for testing purposes just brought everything into my main method, i tries debugging and notices that the pNumber value, does not change whilst in the loop, regardless of the user inputting the values. which has led me to believe they are not being stored on in memory at all.

#include<stdio.h>
#include<stdlib.h>
int main()
{
	int size;
	int *pNumber;

	printf("How many elements are in the array? ");
	scanf_s("%i", &size);

	pNumber = (int *) malloc(size*sizeof(int));

	for(int i = 0; i < size; i++)
	{
		printf("Enter an element of the array: ");
		scanf_s("%i", (pNumber+i));
	}

	printf("%i \n", pNumber);

}

Is this line wrong?

scanf_s("%i", (pNumber+i));

apologies for being a pest, the example in the c book i bought uses values which are hard coded into the program.

[RyanLeonard]

I got it just need to figure out how to print the values in reverse order now. Thanks.