Thread: stone,scissors,paper!

Hi,
I'm trying to write a code for the game Stone-Scissors-Paper.
I faced some problems when it comes to announcing the winner. I get a syntax error in line 62.
I'll appreciate it if someone help me out =)

Code:

/*
 *  File    : pss.c 
 *  Program : Paper, stone, scissors  game
 *  Author  : Sepideh
 */

#include<stdio.h>
#include<stdlib.h>
#include<stdbool.h>
#include<time.h>
#include<string.h>

#define MAX_TURNS 10

#define MAX_BUFFER 6	       

#define DRAW 0
#define COMPUTER_WIN 1
#define HUMAN_WIN 2

#define STONE 0
#define SCISSOR 1
#define PAPER 2

#define STONE_STR "stone"      
#define SCISSOR_STR "scissors"
#define PAPER_STR "paper"





/* ------------------- Utilities ---------------*/
void clear_stdin();
int human_choice();
int computer_choice();
void print_computer_choice();
int winner(int human,int computer);

/***************************************************
 *
 *    MAIN
 *
 ***************************************************/

int main()
{
  int human,
    computer,
    result;
    /*statistic;
    int i;*/
           
  srand( time(0) );
  /* statistic = 0;*/

  printf("Welcome to Paper-Scissors-Stone game by Sepideh!\n"); 

  human=human_choice();
  computer=computer_choice();
  print_computer_choice();
  result=winner(int human,int computer);
    
  /*  Get result depending on choices */
  /*  Print result */

  /*  Update statistics */

  
 
  /* Print total depending on statistics */
 
  return 0;
}

/******************************************************
 *
 *  DEFINITIONS
 * 
 ******************************************************/

void clear_stdin()
{
  while( getchar() != '\n' ){;}
}

int human_choice()
{
  char humanch[10];
  int resultat;
  printf("Your turn!Type your choice.\n");
  scanf("%s",humanch);
  while(strcmp(humanch,STONE_STR)!=0&&strcmp(humanch,SCISSOR_STR)!=0&&strcmp(humanch,PAPER_STR)!=0){
    printf("Wrong entry! Try again.\n");
    scanf("%s",humanch);
  }
  if(humanch=="stone")
    resultat=0;
  if(humanch=="scissors")
    resultat=1;
  if(humanch=="paper")
    resultat=2;
  return resultat;
  void clear_stdin();
}

int computer_choice()
{
  int slumptal;
  slumptal = rand()%3;
  return slumptal;
  printf("%d",slumptal);
}

void print_computer_choice(){
  int slumptal;
  if(slumptal==0)
    printf("stone\n");
  if(slumptal==1)
    printf("scissors\n");
  if(slumptal==2)
    printf("paper\n");
}

int winner(int human,int computer)
{
  int winresult;
  if(human_choice()==computer_choice())
    winresult=0;
  if((human_choice()==0&&computer_choice()==1)||(human_choice()==1&&computer_choice()==2)||(human_choice()==2&&computer_choice()==2))
    winresult=2;
  return winresult;
  /* printf("%d",winresult);*/
}

let me guess, this is line 62:

Code:

  result=winner(int human,int computer);

Remove the int's.

I removed them and get no errors no more =) but when I execute the program it's no good!
and it's certainly because of my other mistakes u said.

But you are also making mistakes of using local variables that should probably be parameters to the function, e.g your slumptal in "print_computer_choice". It is uninitialized.

ok, I'm trying to use the result from the computer_choice function there. how should I do it then? shall I call the "computer_choice" function in "print_computer_choice" function?

Hi again,
I'm still struggling with this code! I used the tips that Mats gave me. Now when I run the program, I write in my choice, computer randoms its choice and then instead of printing the result it goes back to printf("Your turn!Type your choice.\n"); !!
And It keeps going like that 3 or 4 times and then it prints the result. (which actually is correct!!)
It's very strange coz printf("Your turn!Type your choice.\n"); is not in a while loop or so. I don't understand why the program goes back there!
This version of program which I'm writing now should runs only one time and print the result. (It's in future versions where I have to edit it so that it runs 10 times)
Here is the code:

Code:

#include<stdio.h>
#include<stdlib.h>
#include<stdbool.h>
#include<time.h>
#include<string.h>

#define MAX_TURNS 10

#define MAX_BUFFER 6	       

#define DRAW 0
#define COMPUTER_WIN 1
#define HUMAN_WIN 2

#define STONE 0
#define SCISSOR 1
#define PAPER 2

#define STONE_STR "stone"      
#define SCISSOR_STR "scissors"
#define PAPER_STR "paper"





/* ------------------- Utilities ---------------*/
void clear_stdin();
int human_choice();
int computer_choice();
void print_computer_choice();
int winner(int human,int computer);
void print_winner(int result);


/***************************************************
 *
 *    MAIN
 *
 ***************************************************/

int main()
{
  int human,
    computer,

    result;
  /*statistic;
    int i;*/

           
  srand( time(0) );
  /* statistic = 0;*/

  printf("Welcome to Paper-Scissors-Stone game by Sepideh!\n"); 

  human=human_choice();
  computer=computer_choice();
  print_computer_choice();
  result=winner(human,computer);
  print_winner(result);
  
    
  /*  Get result depending on choices */
  /*  Print result */

  /*  Update statistics */

  
 
  /* Print total depending on statistics */
 
  return 0;
}

/******************************************************
 *
 *  DEFINITIONS
 * 
 ******************************************************/

void clear_stdin()
{
  while( getchar() != '\n' ){;}
}

int human_choice()
{
  char humanch[10];
  int resultat;
  printf("Your turn!Type your choice.\n");
  scanf("%s",humanch);
  while(strcmp(humanch,STONE_STR)!=0&&strcmp(humanch,SCISSOR_STR)!=0&&strcmp(humanch,PAPER_STR)!=0){
    printf("Invalid entry! Try again.\n");

    scanf("%s",humanch);
  }

  if(strcmp(humanch,STONE_STR)==0)
    resultat=STONE;
   
  else if(strcmp(humanch,SCISSOR_STR)==0)
    resultat=SCISSOR;
    
  else if(strcmp(humanch,PAPER_STR)==0)
    resultat=PAPER;

  clear_stdin();

  return resultat;
 
}

int computer_choice()
{
  int slumptal;
  slumptal = rand()%3;
  return slumptal;

}

void print_computer_choice(){
  int slumptal;
  if(slumptal==0)
    printf("stone\n");
  if(slumptal==1)
    printf("scissors\n");
  if(slumptal==2)
    printf("paper\n");
}

int winner(int human,int computer)
{
  human=human_choice();
  computer=computer_choice();
  int result;  
  if((human_choice()==0||computer_choice()==1)&&(human_choice()==1||computer_choice()==2)&&(human_choice()==2||computer_choice()==0)){
    result=2;
    printf("a");
  }
  else if((computer_choice()==0||human_choice()==1)&&(computer_choice()==1||human_choice()==2)&&(computer_choice()==2||human_choice()==0)){
    result=1;
    printf("b");
  }
  else {
    result=0;
    printf("c");
  }
  return result;
  
}

void print_winner(int result)
{
  if(result==0)
    printf("No one wins!\n");
  if(result==1)
    printf("Computer wins!\n");
  if(result==2)
    printf("You win!\n");
}

Hmmmm, I really have no clue! The human_choice function prints the message and this function is the first function in the Main function. still not in a loop ...
although in the function winner I use human as one of the arguments. Does this have to do with the problem?! I changed the arguments and get lot of errors now :-S

Originally Posted by matsp

So, what does the line just after the brace in "winner" do?

--
Mats

yepp! I see that now! :"> tnx for the help!

Now I should find out how to use the result of a function in another one. You said this about the variabel slumptal which I used in 2 different functions(hoping that it would have the same value in both functions!) I didn't(couldn't) correct that. but it still works!

tnx again for taking your time.