A simple "printing" calculator... (Yeah, right!!)

[Jodie P]

Hi,

I am a student taking an Intro C programming course and I need help! My assignment is below. I have written the code to best of my ability and it even seems to compile fine, but when I enter numbers into the calculator the whole thing crashes. I have no idea why or even how to go about figuring it out. My "crash" error is at the bottom of the page... Please help me!

My Assignment:
http://calpyso-poet.com/assignment.bmp

My Code:

// Homework 4.cpp : Defines the entry point for the console application.
//
 
#include "stdafx.h"
 
 
int main (void)
{
    float accumulator, value;
    char op;
 
    printf ("Enter number.\n");
 
    do {
        scanf_s ("%f %c", &value, &op);
 
       switch (op)
      {
 
    case 's':
                accumulator = value; break;
 
    case '+':
                accumulator = accumulator + value; break;
 
    case '-':
                accumulator = accumulator - value; break;
 
    case '*':
                accumulator = accumulator * value; break;
 
    case '/':
                if ( value == 0 )
                printf ("Divison by zero does not compute.\n");
             else
                accumulator = accumulator / value; break;
        }
 
            } while (op != 'e' );
    return 0;
}

My Error:
http://calpyso-poet.com/error.bmp

[zacs7]

accumulator isn't initialized (it contains garbage) and then you use it in your calculations.

Consider:
* Initializing your variables (to 0 perhaps)
* Indenting properly
* Shortening your variable names.
* including stdio.h

ie:

float   accum = 0.0f,
        val = 0.0f;
/* etc... */

btw your assignment says 'E' ends the program and 'S' sets the accumulator. C is case-sensitive, you *could* lose marks. 's' isn't the same as 'S'.

I would, read the string from the user using fgets() and use sscanf(), just so there's no possibility they can break it by entering say,

55 S 0 E

That or, flush stdin (don't use fflush(stdin) see the FAQ).

[Salem]

> * Shortening your variable names.
No, they're fine as they are.
Too many noobs show up with single letter identifiers, or identifiers with all the vowels ripped out.