Thread: Memory allocation in linked lists

I'm getting a classic example of printing out a linked list but all nodes contain the value of the last inserted node. I've seen some information about this , but I still cannot figure out how to apply it to my situation. I've attached my code and the test file I've been using. The output I've been getting when I print the linked list is something along the line of:

markets -> markets -> markets -> markets -> (ad nauseum)

It would be greatly appreciated if someone could take a look. I've been stuck on this issue for hours.

Code:

newPtr->data = value;

strcpy is for strings.

I changed that line to

strcpy(value,newPtr->data);

and now I just get a segmentation fault. I didn't think that was an issue, since when I print the linked list, it shows strings at each node.. just the same string over and over.

Woops, tried

strcpy(newPtr->data,value)

like it should be. Still get segmentation fault.

it's just a pointer, you need to change it to an array.

Awesome!! You just helped me fix the biggest problem I had! Now, a new issue is coming up, though. Now the last item input into the linked list doesn't show up in the list. In the test file, "markets." doesn't appear in the end of the linked list. Any ideas?

new code plz.