Thread: need help, fgets won't stop while loop

I'm using the following code in order to order to split up a file into a linked list filled with words and several paragraphs. My question is that it seems that my while loop doesn't seem to be stopping at the end of the file. Is it possible that the file I am using does not an EOF tag or something?

Code:

while(fgets(currentLine, 125, fptr) != 0){

      if(currentLine[0] == '\0'){
         currentPara->nextParagraph = malloc(sizeof(PARAGRAPHPTR));
         currentPara = currentPara->nextParagraph;
         currentPara->start = malloc(sizeof(LISTNODEPTR));
         currentWord = currentPara->start;
         currentWord->nextPtr = NULL;
         currentWord->length = 0;
          printf("After?");
          printf("\n");
      }
      else{ for( i =0; i <= 124 && testChar != 0; i++){
       printf("%d %d ", currentWord->length, i);

         printf("\n");
         testChar = currentLine[i];
         printf("\n");
         if(testChar >= 33 && testChar < 127){
             printf("%c ", testChar);
            currentWord->data[currentWord->length] = testChar;
            currentWord->length++;
       
         }
         else{
            currentWord->nextPtr = malloc(sizeof(LISTNODEPTR));
            currentWord = currentWord->nextPtr;
            currentWord->nextPtr = NULL;
            currentWord->length = 0;
         }

      }
      }
   }

Thanks for your help.

Keep calling feof to determine if you've reached the end of the file. feof returns true after the first read operations that tries to read beyond the end of the file.
It's usually better to do an infinite loop or something and check for end-of-file with feof and break when feof(...) == true.

Code:

while(fgets(currentLine, 125, fptr) != NULL){

And dont use feof read FAQ

ssharish

feof is fine if you use it after a read. Just don't use it as a loop condition.
fgets can fail even if it didn't read past the end of the file (read error from disk, maybe, CRC error).

I changed the 0 to NULL, and added the following:

Code:

if(feof(fPtr))
   break;

at the beginning of the loop and it still gets stuck in an infinite loop.

Could the data member being poorly allocated or buffer overflow cause this to get caught in an infinite loop? Here's the declaration and the allocation:

Code:

struct listNode {  /* self-referential structure */
   char data[30];
   int length;/*Length of the word, will actually be low by one*/
   struct listNode *nextPtr;
};
typedef struct listNode LISTNODE;
typedef LISTNODE *LISTNODEPTR;

struct paragraph { /* The starting nodes of each paragraph, as well as links to the next paragraph*/
   LISTNODEPTR start;
   struct paragraph *nextParagraph; 
};

typedef struct paragraph *PARAGRAPHPTR;


void insert(LISTNODEPTR *);
void pop(LISTNODEPTR *, char[]);
int isEmpty(LISTNODEPTR);

main()
{
   /* Declarations */

   char currentLine[125];
   char tempWord[30];
   int wordsInLine, extraSpaces;
   int linePos, lineSize, wordSize=0;
   int i, j;
   char filename[20];   
   FILE *fptr;
   int testChar = '0';
   int newParagraph = FALSE;
   int newWord = FALSE;
   LISTNODEPTR endOfLine;
   LISTNODEPTR startOfFile;
   endOfLine = malloc(sizeof(LISTNODEPTR));
   startOfFile = malloc(sizeof(LISTNODEPTR));

   startOfFile->nextPtr = NULL;


   startOfFile->length = 0;
   PARAGRAPHPTR firstPara;
   firstPara = malloc(sizeof(PARAGRAPHPTR));
   firstPara->start = startOfFile;
   firstPara->nextParagraph = NULL;
   PARAGRAPHPTR currentPara = firstPara;
   LISTNODEPTR currentWord = startOfFile;
   currentWord->length = 0;
   printf("%d ", currentWord->length);



 /* Get the file and user input*/
   printf("Please input the file that you would like to get text from\n");
   scanf("%s", filename);
   fptr = fopen(filename, "r");
    
   printf("Please input the number of characters per line for the text\n");
   scanf("%d", &lineSize);
   currentWord->length = 0;
   /*Put the file into paragraphs*/

and then the above code is used. I know that it's an infinite loop, it's not exiting early or anything. Thanks for your help.