Thread: Problems with buffers

I would like to have my client.c program send a get message to a host port 80 and receive the ENTIRE index.html and print to screen.

For some reason even if I up the char buf[1000000] I still can't capture the entire file.
Is there a better way to do this than by allocating 1000000 space?

Code:

#include <stdio.h>
#include <sys/types.h>
#include <sys/socket.h>
#include <netinet/in.h>
#include <netdb.h>

void error(char *msg)
{
    perror(msg);
    exit(0);
}

int main(int argc, char *argv[])
{
    int sockfd, portno, n;
    struct sockaddr_in serv_addr;
    struct hostent *server;
    char buffer[1000000];

    if (argc < 3) {
       fprintf(stderr,"usage %s hostname port\n", argv[0]);
       exit(0);
    }
    portno = atoi(argv[2]);
    sockfd = socket(AF_INET, SOCK_STREAM, 0);
    if (sockfd < 0)
        error("ERROR opening socket");
    server = gethostbyname(argv[1]);
    if (server == NULL) {
        fprintf(stderr,"ERROR, no such host\n");
        exit(0);
    }
    bzero((char *) &serv_addr, sizeof(serv_addr));
    serv_addr.sin_family = AF_INET;
    bcopy((char *)server->h_addr,
         (char *)&serv_addr.sin_addr.s_addr,
         server->h_length);
    serv_addr.sin_port = htons(portno);
    if (connect(sockfd,&serv_addr,sizeof(serv_addr)) < 0)
        error("ERROR connecting");
    printf("Please enter the message: ");
    bzero(buffer,256);
    fgets(buffer,255,stdin);
    n = write(sockfd,buffer,strlen(buffer));
    if (n < 0)
         error("ERROR writing to socket");
    bzero(buffer,1000000);
    n = read(sockfd,buffer,1000000);
    if (n < 0)
         error("ERROR reading from socket");
    printf("%s\n",buffer);
    return 0;

[edit]
Never mind found it.
[/edit]

I keep getting error
client.c:60: error: syntax error at end of input

Code:

unsigned char c;
while(read(sockfd,&c,1) >= 0) putchar(c);

still doesn't work.
Just blank space

Code:

#include <stdio.h>
#include <sys/types.h>
#include <sys/socket.h>
#include <netinet/in.h>
#include <netdb.h>

void error(char *msg)
{
    perror(msg);
    exit(0);
}

int main(int argc, char *argv[])
{
    int sockfd, portno, n;
    struct sockaddr_in serv_addr;
    struct hostent *server;
    char buffer[256];
    unsigned char c;

    if (argc < 3) {
       fprintf(stderr,"usage %s hostname port\n", argv[0]);
       exit(0);
    }
    portno = atoi(argv[2]);
    sockfd = socket(AF_INET, SOCK_STREAM, 0);
    if (sockfd < 0)
        error("ERROR opening socket");
    server = gethostbyname(argv[1]);
    if (server == NULL) {
        fprintf(stderr,"ERROR, no such host\n");
        exit(0);
    }
    bzero((char *) &serv_addr, sizeof(serv_addr));
    serv_addr.sin_family = AF_INET;
    bcopy((char *)server->h_addr,
         (char *)&serv_addr.sin_addr.s_addr,
         server->h_length);
    serv_addr.sin_port = htons(portno);
    if (connect(sockfd,&serv_addr,sizeof(serv_addr)) < 0)
        error("ERROR connecting");
    printf("Please enter the message: ");
    bzero(buffer,256);
    fgets(buffer,255,stdin);
    n = write(sockfd,buffer,strlen(buffer));
    if (n < 0)
         error("ERROR writing to socket");
    bzero(buffer,256);
    //n = read(sockfd,buffer,1000000);
    //if (n < 0)
     //    error("ERROR reading from socket");
    //printf("%s\n",buffer);

    while(read(sockfd,&c,1) >= 0) putchar(c);
    return 0;
}
~

Did not work
Anyone else?

That does not fix it.

Assuming you read the source code you will see where I do send a message to the server.

I do receive the first 300 bytes or so of the index file. That is all.
Hence why I said is it a buffer situation.
But now after using the other guys putchar methods I don't get anything except blank space.

Closing the socket is the last thing I would do before returning 0.
However, closing the socket has nothing to do with reading it.

Let's forget the buffer.
Can I just create a 'buffer' that can expand or allocate as needed.
I do not know how large each site will be.
Can't I just create a variable to hold all sizes?