function compile error

[kiz]

cant see why this wont compile

#include <stdio.h>
#include <ep100lib.h>

int Image_Invert(int image_data[height][width], int height, int width)
{
int row, column, red, green, blue;

for(row=0;row <= height; row++)
	{
	for(column=0; column<= width; column++);
		{
		red = 255-((image_data[row][column]>>16)&0xff);
		green = 255-((image_data[row][column]>>8)&0xff);
		blue = 255-((image_data[row][column])&0xff);
		image_data[row][column] = ((red<<16)&(green<<8)&(blue));
		}
	}
return image_data;
}

int main(int argc, char **argv)
{
char               *file = NULL;
int                 no = 1;
int height;
int width;
int image_data[EP100_LIB_MAX_X][EP100_LIB_MAX_Y];

	if (argc < 2)		// if there are not enough arguments.
		return 1;

	// now your code to get and process the CLA.....

	file = argv[no];

	ep100_lib_init();		// Initialise the ep100 library of routines.		return 1;

	// now your code to get and process the CLA.....

	file = argv[no];

	ep100_lib_init();		// Initialise the ep100 library of routines.

	ep100_lib_open_image(file);

	height=ep100_lib_get_image_height();
	width=ep100_lib_get_image_width();
	fprintf(stdout,"Image is %dx%d\n",width,height);

	
	ep100_lib_get_data(image_data);
	ep100_lib_print_data(image_data);
	
	image_data[height][width] = Image_Invert(image_data[height][width], height, width);

//	image_process_invert_data(image_data);
	
//	ep100_lib_set_data(image_process_emboss_data(image_data));

	ep100_lib_set_data(image_data);

	sleep(5);		// This gives us a chance to see the orginal and then the new one appears
	ep100_lib_display_image();	// Click in the window to exit the program, button 3 zooms

	ep100_lib_close();

   return 0;
}

the errors are because of the Image_Invert function

these are the errors

cc -I. -I/usr/units/ep100/ass2.072/ `imlib2-config --cflags` -g   -c -o Image.o Image.c
Image.c:4: error: âheightâ undeclared here (not in a function)
Image.c:4: error: âwidthâ undeclared here (not in a function)
Image.c: In function âmainâ:
Image.c:54: error: type of formal parameter 1 is incomplete
make: *** [Image.o] Error 1

does anyone know how i can fix it??

[Salem]

> int Image_Invert(int image_data[height][width], int height, int width)
This needs to be
int Image_Invert(int image_data[EP100_LIB_MAX_X][EP100_LIB_MAX_Y], int height, int width)

> return image_data;
You can't return a whole array, and this just returns the passed in pointer.
But since your return type is int, this is the wrong type anyway.
Since the array was passed as a pointer, all the changes have been made to the original anyway.

And the call needs to be
Image_Invert(image_data, height, width);

> for(column=0; column<= width; column++);
1. Watch the ; at the end
2. Do you really mean <= here, given that you start at 0
Look up "fence-post" errors on the web.

[matsp]

This bit is duplicated:

	// now your code to get and process the CLA.....

	file = argv[no];

	ep100_lib_init();		// Initialise the ep100 library of routines.		return 1;

	sleep(5);		// This gives us a chance to see the orginal and then the new one appears

Use something that waits for the user to press enter or such - not a static 5 second time, it may get annoyingly long if you are not interested in seeing the original image, and it's almost certainly too short if you really want to study the original.

		image_data[row][column] = ((red<<16)&(green<<8)&(blue));

Will almost certainly be zero always.


--
Mats