linked list problem

[ozumsafa]

#include <stdio.h>
#include <stdlib.h>
typedef struct linkledlist {
 char data;
struct linkedlist *nextptr;
} DEFINE;



void insert(DEFINE  **,char);
int main(int argc, char *argv[])
{
DEFINE  *startptr;
startptr=NULL;
startptr->nextptr=NULL;
printf("Choose what to do  (1) to add , (2) to delete , q to quit....");
char selection;
char toadd;
scanf("%c",&selection);
switch(selection) {
case 1:
  {
 printf("Enter character to add :");
scanf("%c",&toadd);
printf("x");
insert(&startptr,toadd);
} }

printf("%c",startptr->data);
return 0;
printf("x");
 
 
}


void insert(DEFINE  **sptr,char value) {
DEFINE *newptr=malloc(sizeof(DEFINE));
DEFINE *previous;
DEFINE *current;
if(newptr!=NULL) {newptr->data=value;
newptr->nextptr=NULL; }
previous=NULL;
current=*sptr;

while(current!=NULL && value>current->data) { 
previous=current;
current=current->nextptr;} ////////////////

if(previous==NULL) {
newptr->nextptr=*sptr;  ////////////////////////////
*sptr=newptr; }
else {
newptr->nextptr=current;       /////////////////////////
previous->nextptr=newptr; }//////////////
}

It will be a program which is capable of adding chars and deleting chars from a linkedlist. But I get this error from compile :

55 C:\Dev-Cpp\projects\main.c [Warning] assignment from incompatible pointer type

It gives this error , for all the lines I have mentioned by slashes. 'd be glad if you helped.

[matsp]

You've been posting here long enough to have some understanding that if you don't indent your code, you probably don't get much help.

--
Mats

[ozumsafa]

Yes you are true.I have thought of it. But then I thought that the problem was not about the whole code. So I did not. But if you say so , I will do it then I will expect some answers. Thank you.

[ozumsafa]

By the way, by intending you mean , explainin aims of lines?

[matsp]

No I mean Indenting:
Un-indented code:

int main() {
for(i=0; i < 10; i++) {
printf("&#37;d", i);
for(j=0; j < 10; j++) {
printf("%d", j);
}
}
}

Same code indented:

int main() {
  for(i=0; i < 10; i++) {
    printf("%d", i);
    for(j=0; j < 10; j++) {
      printf("%d", j);
    }
  }
}

It shows the relationship between the control structures and the code within them.

--
Mats

[matsp]

Some comments on the code:
1.

DEFINE  *startptr;
startptr=NULL;
startptr->nextptr=NULL;

this will crash the application - writing to NULL is a definite bad thing.

2. If you are using C, rather than C++, declare all variables first, then put code after the declarations.

printf("Choose what to do  (1) to add , (2) to delete , q to quit....");
char selection;
char toadd;

3. Don't put code that you expect to execute AFTER a return.

 return 0;
printf("x");

4. Your actual compile problem is caused by a typo:

struct linkledlist { 
...
struct linkedlist *nextptr;
}

- there is an extra letter l in the first struct name, that isn't in the second struct name. The compiler will think that the second struct is a different type, and of course give the warning you are describing.

Edit: And don't use a name like "DEFINE" as a typename...

--
Mats

[ozumsafa]

I have already changed that printf after return. That is a fatal mistake. But that was about a moment anyway. And about the main problem . that is disgusting that I have made a mistake which is completely about syntax error. How could not I see that extra `l` there. Thank you.